From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Sun, 12 Mar 2017 14:56:53 +0000 Subject: Re: [PATCH] staging: atomisp: clean up return logic, remove redunant code Message-Id: <58C561B5.8080102@bfs.de> List-Id: References: <20170311193205.6410-1-colin.king@canonical.com> In-Reply-To: <20170311193205.6410-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Alan Cox , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Am 11.03.2017 20:32, schrieb Colin King: > From: Colin Ian King > > There is no need to check if ret is non-zero, remove this > redundant check and just return the error status from the call > to mt9m114_write_reg_array. > > Detected by CoverityScan, CID#1416577 ("Identical code for > different branches") > > Signed-off-by: Colin Ian King > --- > drivers/staging/media/atomisp/i2c/mt9m114.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c > index 8762124..a555aec 100644 > --- a/drivers/staging/media/atomisp/i2c/mt9m114.c > +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c > @@ -444,12 +444,8 @@ static int mt9m114_set_suspend(struct v4l2_subdev *sd) > static int mt9m114_init_common(struct v4l2_subdev *sd) > { > struct i2c_client *client = v4l2_get_subdevdata(sd); > - int ret; > > - ret = mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING); > - if (ret) > - return ret; > - return ret; > + return mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING); > } any use for "client" ? re, wh > > static int power_ctrl(struct v4l2_subdev *sd, bool flag)