From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Wed, 28 Jun 2017 14:49:03 +0000 Subject: Re: [PATCH] staging: speakup: make function ser_to_dev static Message-Id: <5953C1DF.5010201@bfs.de> List-Id: References: <20170628131351.22106-1-colin.king@canonical.com> In-Reply-To: <20170628131351.22106-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Greg Kroah-Hartman , Okash Khawaja , Andy Shevchenko , Alexandre Ghiti , Dan Carpenter , Rui Teng , speakup@linux-speakup.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Am 28.06.2017 15:13, schrieb Colin King: > From: Colin Ian King > > The helper function ser_to_dev does not need to be in global scope, so > make it static. > > Cleans up sparse warning: > "warning: symbol 'ser_to_dev' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King > --- > drivers/staging/speakup/spk_ttyio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c > index 442f191a017e..ed8e96b06ead 100644 > --- a/drivers/staging/speakup/spk_ttyio.c > +++ b/drivers/staging/speakup/spk_ttyio.c > @@ -21,7 +21,7 @@ struct spk_ldisc_data { > static struct spk_synth *spk_ttyio_synth; > static struct tty_struct *speakup_tty; > > -int ser_to_dev(int ser, dev_t *dev_no) > +static int ser_to_dev(int ser, dev_t *dev_no) > { > if (ser < 0 || ser > (255 - 64)) { > pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n"); Is there any remark, why the programmer decided to use (255 - 64) instead of 191 ? re, wh