From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: dell-smbios: Fix error handling in build_tokens_sysfs()
Date: Thu, 18 Jan 2018 11:20:26 +0000 [thread overview]
Message-ID: <5A6082FA.1040608@bfs.de> (raw)
In-Reply-To: <20180118110334.v33ypxsavbmq6qpu@mwanda>
Am 18.01.2018 12:03, schrieb Dan Carpenter:
> On Thu, Jan 18, 2018 at 11:50:30AM +0100, walter harms wrote:
>>> @@ -523,7 +523,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
>>> return 0;
>>>
>>> out_unwind_strings:
>>> - for (i = i-1; i > 0; i--) {
>>> + for (i = i-1; i >= 0; i--) {
>>> kfree(token_location_attrs[i].attr.name);
>>> kfree(token_value_attrs[i].attr.name);
>>> }
>>
>> would you mind to reverse order here ?
>> you know programmers are terrible at couting backwards.
>
> I prefer to always unwind in reverse order so I'd prefer to leave it
> as-is.
It is just a comment from my side. we can leave the actual decision to the
current maintainer.
re,
wh
>
> regards,
> dan carpenter
>
>
next prev parent reply other threads:[~2018-01-18 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 10:45 [PATCH] platform/x86: dell-smbios: Fix error handling in build_tokens_sysfs() Dan Carpenter
2018-01-18 10:50 ` walter harms
2018-01-18 11:03 ` Dan Carpenter
2018-01-18 11:20 ` walter harms [this message]
2018-01-18 19:21 ` Andy Shevchenko
2018-01-18 19:24 ` Andy Shevchenko
2018-01-19 23:59 ` Pali Rohár
2018-01-19 18:32 ` Mario.Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A6082FA.1040608@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox