* [PATCH spark] sparc: vDSO: remove an extra tab
@ 2018-01-19 13:23 Dan Carpenter
2018-01-19 18:09 ` nagarathnam muthusamy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-01-19 13:23 UTC (permalink / raw)
To: kernel-janitors
This statement is indented one tab too far which is confusing and
leads to a Smatch warning:
arch/sparc/vdso/vma.c:254 arch_setup_additional_pages()
warn: curly braces intended?
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/sparc/vdso/vma.c b/arch/sparc/vdso/vma.c
index 0a6f50098e23..f51595f861b8 100644
--- a/arch/sparc/vdso/vma.c
+++ b/arch/sparc/vdso/vma.c
@@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
else
return map_vdso(&vdso_image_32_builtin, &vdso_mapping32);
#else
- return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
+ return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
#endif
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH spark] sparc: vDSO: remove an extra tab
2018-01-19 13:23 [PATCH spark] sparc: vDSO: remove an extra tab Dan Carpenter
@ 2018-01-19 18:09 ` nagarathnam muthusamy
2018-01-19 18:19 ` Dan Carpenter
2018-01-22 20:01 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: nagarathnam muthusamy @ 2018-01-19 18:09 UTC (permalink / raw)
To: kernel-janitors
On 1/19/2018 5:23 AM, Dan Carpenter wrote:
> This statement is indented one tab too far which is confusing and
> leads to a Smatch warning:
>
> arch/sparc/vdso/vma.c:254 arch_setup_additional_pages()
> warn: curly braces intended?
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/sparc/vdso/vma.c b/arch/sparc/vdso/vma.c
> index 0a6f50098e23..f51595f861b8 100644
> --- a/arch/sparc/vdso/vma.c
> +++ b/arch/sparc/vdso/vma.c
> @@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
> else
> return map_vdso(&vdso_image_32_builtin, &vdso_mapping32);
> #else
> - return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
> + return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
> #endif
>
> }
Should the subject be sparc instead of spark? Other than that,
Reviewed-by: Nagarathnam Muthusamy <nagarathnam.muthusamy@oracle.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH spark] sparc: vDSO: remove an extra tab
2018-01-19 13:23 [PATCH spark] sparc: vDSO: remove an extra tab Dan Carpenter
2018-01-19 18:09 ` nagarathnam muthusamy
@ 2018-01-19 18:19 ` Dan Carpenter
2018-01-22 20:01 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-01-19 18:19 UTC (permalink / raw)
To: kernel-janitors
On Fri, Jan 19, 2018 at 10:09:44AM -0800, nagarathnam muthusamy wrote:
>
> Should the subject be sparc instead of spark? Other than that,
>
Stupid iphone auto corrects all my emails... Just kidding, I made that
typo. Fortunately, that part doesn't get saved to the final git log.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH spark] sparc: vDSO: remove an extra tab
2018-01-19 13:23 [PATCH spark] sparc: vDSO: remove an extra tab Dan Carpenter
2018-01-19 18:09 ` nagarathnam muthusamy
2018-01-19 18:19 ` Dan Carpenter
@ 2018-01-22 20:01 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-01-22 20:01 UTC (permalink / raw)
To: kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 19 Jan 2018 21:19:39 +0300
> On Fri, Jan 19, 2018 at 10:09:44AM -0800, nagarathnam muthusamy wrote:
>>
>> Should the subject be sparc instead of spark? Other than that,
>>
>
> Stupid iphone auto corrects all my emails... Just kidding, I made that
> typo. Fortunately, that part doesn't get saved to the final git log.
Applied, thanks :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-22 20:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 13:23 [PATCH spark] sparc: vDSO: remove an extra tab Dan Carpenter
2018-01-19 18:09 ` nagarathnam muthusamy
2018-01-19 18:19 ` Dan Carpenter
2018-01-22 20:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox