* [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default @ 2018-02-09 6:13 jiangyiwen 2018-02-24 2:47 ` jiangyiwen 0 siblings, 1 reply; 4+ messages in thread From: jiangyiwen @ 2018-02-09 6:13 UTC (permalink / raw) To: v9fs-developer Cc: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov, linux-kernel, kernel-janitors User use some syscall, for example mmap(v9fs_file_mmap), it will not update atime even if user's mnt_flags have MNT_NOATIME, because v9fs default set SB_NOATIME in v9fs_set_super. For supporting access time is updated when user mount with relatime, we should clear SB_NOATIME by default. Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> --- fs/9p/vfs_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c index af03c2a..48ce504 100644 --- a/fs/9p/vfs_super.c +++ b/fs/9p/vfs_super.c @@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data) if (v9ses->cache) sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE; - sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME; + sb->s_flags |= SB_ACTIVE | SB_DIRSYNC; if (!v9ses->cache) sb->s_flags |= SB_SYNCHRONOUS; -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default 2018-02-09 6:13 [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default jiangyiwen @ 2018-02-24 2:47 ` jiangyiwen 2018-02-26 1:34 ` jiangyiwen 0 siblings, 1 reply; 4+ messages in thread From: jiangyiwen @ 2018-02-24 2:47 UTC (permalink / raw) To: v9fs-developer, viro Cc: ericvh, rminnich, kernel-janitors, linux-kernel, Latchesar Ionkov, Greg Kurz On 2018/2/9 14:13, jiangyiwen wrote: > User use some syscall, for example mmap(v9fs_file_mmap), it will not > update atime even if user's mnt_flags have MNT_NOATIME, because > v9fs default set SB_NOATIME in v9fs_set_super. > > For supporting access time is updated when user mount with relatime, > we should clear SB_NOATIME by default. > > Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> > --- > fs/9p/vfs_super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c > index af03c2a..48ce504 100644 > --- a/fs/9p/vfs_super.c > +++ b/fs/9p/vfs_super.c > @@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data) > if (v9ses->cache) > sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE; > > - sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME; > + sb->s_flags |= SB_ACTIVE | SB_DIRSYNC; > if (!v9ses->cache) > sb->s_flags |= SB_SYNCHRONOUS; > Hi Alexander Viro and Eric, My patch has already sent two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch? I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem. Thanks, Yiwen. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default 2018-02-24 2:47 ` jiangyiwen @ 2018-02-26 1:34 ` jiangyiwen 2018-02-26 5:28 ` Bo YU 0 siblings, 1 reply; 4+ messages in thread From: jiangyiwen @ 2018-02-26 1:34 UTC (permalink / raw) To: Andrew Morton Cc: v9fs-developer, viro, ericvh, rminnich, kernel-janitors, linux-kernel, Latchesar Ionkov, Greg Kurz On 2018/2/24 10:47, jiangyiwen wrote: > On 2018/2/9 14:13, jiangyiwen wrote: >> User use some syscall, for example mmap(v9fs_file_mmap), it will not >> update atime even if user's mnt_flags have MNT_NOATIME, because >> v9fs default set SB_NOATIME in v9fs_set_super. >> >> For supporting access time is updated when user mount with relatime, >> we should clear SB_NOATIME by default. >> >> Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> >> --- >> fs/9p/vfs_super.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c >> index af03c2a..48ce504 100644 >> --- a/fs/9p/vfs_super.c >> +++ b/fs/9p/vfs_super.c >> @@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data) >> if (v9ses->cache) >> sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE; >> >> - sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME; >> + sb->s_flags |= SB_ACTIVE | SB_DIRSYNC; >> if (!v9ses->cache) >> sb->s_flags |= SB_SYNCHRONOUS; >> > Hi Alexander Viro and Eric, > > My patch has already sent two weeks, but nobody help me > to review, I have a question about now who is the v9fs's > maintainer? Or who can help me review the patch? > > I hope v9fs's maintainer can give me some advices or > merge into the mainline if it has no problem. > > Thanks, > Yiwen. > Hi Andrew, My patch has already sent more than two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch? I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem. Thanks, Yiwen. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default 2018-02-26 1:34 ` jiangyiwen @ 2018-02-26 5:28 ` Bo YU 0 siblings, 0 replies; 4+ messages in thread From: Bo YU @ 2018-02-26 5:28 UTC (permalink / raw) To: jiangyiwen Cc: Andrew Morton, v9fs-developer, viro, ericvh, rminnich, kernel-janitors, linux-kernel, Latchesar Ionkov, Greg Kurz Hi, I think you would better to modify the subject line without [V9fs-developers]. On Mon, Feb 26, 2018 at 09:34:49AM +0800, jiangyiwen wrote: >On 2018/2/24 10:47, jiangyiwen wrote: >> On 2018/2/9 14:13, jiangyiwen wrote: >>> User use some syscall, for example mmap(v9fs_file_mmap), it will not >>> update atime even if user's mnt_flags have MNT_NOATIME, because >>> v9fs default set SB_NOATIME in v9fs_set_super. >>> >>> For supporting access time is updated when user mount with relatime, >>> we should clear SB_NOATIME by default. >>> >>> Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> >>> --- >>> fs/9p/vfs_super.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c >>> index af03c2a..48ce504 100644 >>> --- a/fs/9p/vfs_super.c >>> +++ b/fs/9p/vfs_super.c >>> @@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data) >>> if (v9ses->cache) >>> sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE; >>> >>> - sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME; >>> + sb->s_flags |= SB_ACTIVE | SB_DIRSYNC; >>> if (!v9ses->cache) >>> sb->s_flags |= SB_SYNCHRONOUS; >>> >> Hi Alexander Viro and Eric, >> >> My patch has already sent two weeks, but nobody help me >> to review, I have a question about now who is the v9fs's >> maintainer? Or who can help me review the patch? >> >> I hope v9fs's maintainer can give me some advices or >> merge into the mainline if it has no problem. >> >> Thanks, >> Yiwen. >> >Hi Andrew, > >My patch has already sent more than two weeks, but nobody >help me to review, I have a question about now who is the >v9fs's maintainer? Or who can help me review the patch? > There is no maintainer with V9fs in get_maintain.pl and V9fs git tree laterest commit before two years.so,situation become bad. Maybe you eamil linus directly,although this is't good >I hope v9fs's maintainer can give me some advices or >merge into the mainline if it has no problem. > >Thanks, >Yiwen. > >-- >To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-26 5:28 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-02-09 6:13 [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default jiangyiwen 2018-02-24 2:47 ` jiangyiwen 2018-02-26 1:34 ` jiangyiwen 2018-02-26 5:28 ` Bo YU
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox