From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [media] Siano: Use common error handling code in smsusb_init_device()
Date: Wed, 20 Sep 2017 17:18:31 +0000 [thread overview]
Message-ID: <5c4e91c6-80fd-e17a-d165-b8d4a5e5ce14@users.sourceforge.net> (raw)
In-Reply-To: <20170920135605.sneukaioeabalkud@mwanda>
> If smscore_register_device() succeeds then mdev is freed when we call
> smsusb_term_device(intf); The call tree is:
Thanks for your constructive information.
How do you think about another implementation detail in this function then?
May the statement “kfree(mdev);” be executed before “smsusb_term_device(intf);”
in one if branch?
Regards,
Markus
prev parent reply other threads:[~2017-09-20 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 12:40 [PATCH] [media] Siano: Use common error handling code in smsusb_init_device() SF Markus Elfring
2017-09-20 13:56 ` Dan Carpenter
2017-09-20 17:18 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c4e91c6-80fd-e17a-d165-b8d4a5e5ce14@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).