From: haver <haver@linux.vnet.ibm.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org,
"Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] GenWQE: constify pci_error_handlers structures
Date: Mon, 09 Oct 2017 07:08:59 +0000 [thread overview]
Message-ID: <5e23b4b0a5cd36df134d97c61cecb24b@linux.vnet.ibm.com> (raw)
In-Reply-To: <1502516674-8918-3-git-send-email-Julia.Lawall@lip6.fr>
On 2017-08-12 07:44, Julia Lawall wrote:
> These pci_error_handlers structures are only stored in the err_handler
> field of a pci_driver structure, and this field is declared as const.
> Thus
> the pci_error_handlers structures can be const too.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/misc/genwqe/card_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/genwqe/card_base.c
> b/drivers/misc/genwqe/card_base.c
> index 4fd21e8..8650046 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -1333,7 +1333,7 @@ static int genwqe_sriov_configure(struct pci_dev
> *dev, int numvfs)
> return 0;
> }
>
> -static struct pci_error_handlers genwqe_err_handler = {
> +static const struct pci_error_handlers genwqe_err_handler = {
> .error_detected = genwqe_err_error_detected,
> .mmio_enabled = genwqe_err_result_none,
> .slot_reset = genwqe_err_slot_reset,
Fine with me. Thanks for the contribution.
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
next prev parent reply other threads:[~2017-10-09 7:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 5:44 [PATCH 0/6] constify pci_error_handlers structures Julia Lawall
2017-08-12 5:44 ` [PATCH 1/6] scsi: mpt3sas: " Julia Lawall
2017-08-12 5:44 ` [PATCH 2/6] GenWQE: " Julia Lawall
2017-10-09 7:08 ` haver [this message]
2017-08-12 5:44 ` [PATCH 3/6] scsi: aacraid: " Julia Lawall
2017-08-13 2:32 ` Dave Carroll
2017-08-12 5:44 ` [PATCH 4/6] scsi: be2iscsi: " Julia Lawall
2017-08-12 5:44 ` [PATCH 5/6] [SCSI] csiostor: " Julia Lawall
2017-08-12 5:44 ` [PATCH 6/6] bfa: " Julia Lawall
2017-08-12 7:44 ` [PATCH 0/6] " Christoph Hellwig
2017-08-12 7:52 ` Julia Lawall
2017-08-12 7:56 ` Christoph Hellwig
2017-08-12 8:00 ` Julia Lawall
2017-08-12 11:51 ` Julia Lawall
2017-08-13 14:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e23b4b0a5cd36df134d97c61cecb24b@linux.vnet.ibm.com \
--to=haver@linux.vnet.ibm.com \
--cc=Julia.Lawall@lip6.fr \
--cc=bhumirks@gmail.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox