From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 901DAC433F5 for ; Mon, 4 Oct 2021 23:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6258261462 for ; Mon, 4 Oct 2021 23:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235454AbhJDXhk (ORCPT ); Mon, 4 Oct 2021 19:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235449AbhJDXhj (ORCPT ); Mon, 4 Oct 2021 19:37:39 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED6CC061749 for ; Mon, 4 Oct 2021 16:35:49 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id i4so79098208lfv.4 for ; Mon, 04 Oct 2021 16:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bAbUrq+YEGQ8QqX2x0huaegjL+DVKSS+ia5e1PaJxbQ=; b=g7W5OPmi1aIkzDo+3ETFXRiySovtja0OIr8nT1tL7ZjQT6aVgeLI26HzuGEdUdqcDy 6qld8PFaqKQdAmJ679ADX84uIOf2HkayYVSsR41TsYUcnkwQJs3hgjnAqmCHkg4NXtgJ ihA7XLOzqxkEoucEGw/bX4GQ0ibaJbjBSFWJ0TOnW3t7+Mh3W/M6eZIFWgsOWEnLb+y3 gn2UGWrwDGOxDvikkhXLLuxfX9y4fZaCiMt95rE6LpFVYSAmzogbHBYgtFdiT07JLTJ2 thTmql+V3bde0RKqBUPKY1tBmkOnwRNATvsL+Twdpo2Z+70+DZKGhLaPD5TFnLbYeH0x jxTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bAbUrq+YEGQ8QqX2x0huaegjL+DVKSS+ia5e1PaJxbQ=; b=le4Zn6YJfy3Ql6RrPGRqtOjledO3SYDcvaHJGj88lpxBp5uR9G18JiSHsWTDJF5KDh E4Z7uOOmzXC4BXboSGZglGcC87YitO7bf6o+hYt+af2KG5IGX/LKQNDGJEFp/sfxE41w Q4jd5YhMRa/D6LTsdVf/SBs8S5pTJMiZFkEJ2I1MXXco34QtCrQAFKvMW23lkRS72pIi MY9YelTF0EC4++vpfqoalpaPf/gUgFs8wZq9hHUehWV2CGZRFwHvYfroP02FKca3GxeS ntfJAllZ5wJC+Tel25PmIXRWUg2Ocs/A2bFgte/vnn0bV1yl/e87JPbApTkdwr29gIUW dlEQ== X-Gm-Message-State: AOAM532aZCQKQrnKLx3VlYcxAhhXmPh8qfZxdL6G9LsVfAbuJ0/Wu8o4 9zNbwS6xod/lLkZhsPgtkca5OvsmTIVzSA== X-Google-Smtp-Source: ABdhPJxqEOfRrI4DMjINIanU3R0WVfP1o4DgyUrQI2RwWT4K/iTMKPHT32fSDRakRbU/hei4nH9Vbw== X-Received: by 2002:a05:6512:33c2:: with SMTP id d2mr33196lfg.18.1633390547930; Mon, 04 Oct 2021 16:35:47 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id g27sm276458lfh.162.2021.10.04.16.35.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Oct 2021 16:35:47 -0700 (PDT) Subject: Re: [PATCH] drm/msm: potential error pointer dereference in init() To: Dan Carpenter , Rob Clark , Jordan Crouse Cc: Sean Paul , David Airlie , Daniel Vetter , Abhinav Kumar , Viresh Kumar , Bjorn Andersson , Kalyan Thota , Xu Wang , Jonathan Marek , Yangtao Li , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org References: <20211004103806.GD25015@kili> From: Dmitry Baryshkov Message-ID: <60e7beb3-e54b-6367-0989-e0f780a34b52@linaro.org> Date: Tue, 5 Oct 2021 02:35:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211004103806.GD25015@kili> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 04/10/2021 13:38, Dan Carpenter wrote: > The msm_iommu_new() returns error pointers on failure so check for that > to avoid an Oops. > > Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Dmitry Baryshkov > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index ae48f41821cf..ad247c06e198 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -908,6 +908,10 @@ static int _dpu_kms_mmu_init(struct dpu_kms *dpu_kms) > return 0; > > mmu = msm_iommu_new(dpu_kms->dev->dev, domain); > + if (IS_ERR(mmu)) { > + iommu_domain_free(domain); > + return PTR_ERR(mmu); > + } > aspace = msm_gem_address_space_create(mmu, "dpu1", > 0x1000, 0x100000000 - 0x1000); > > -- With best wishes Dmitry