From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Date: Wed, 03 May 2017 21:46:43 +0000 Subject: Re: [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp() Message-Id: <62ab0dcd-bf74-677d-7ee5-15a02230b2b6@broadcom.com> List-Id: References: <20170503212215.m2t2rfrkoktugkg4@mwanda> In-Reply-To: <20170503212215.m2t2rfrkoktugkg4@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org On 5/3/2017 2:22 PM, Dan Carpenter wrote: > There is a double lock bug here so this will deadlock instead of > unlocking. > > Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c > Yep. looks good Reviewed-by: James Smart