From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jani Nikula <jani.nikula@linux.intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer()
Date: Tue, 24 Oct 2017 13:17:47 +0000 [thread overview]
Message-ID: <636f6272-9074-53dc-2c90-cbb4a7cd0901@users.sourceforge.net> (raw)
In-Reply-To: <87efpsiu7r.fsf@intel.com>
>> Add a jump target so that a call of the function "gvt_vgpu_err" is stored
>> only once at the end of this function implementation.
>> Replace two calls by goto statements.
>>
>> This issue was detected by using the Coccinelle software.
>
> I don't think this is an issue or an improvement.
Do you care for the detail how often an error message is stored in the code?
Regards,
Markus
next prev parent reply other threads:[~2017-10-24 13:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 12:25 [PATCH] drm/i915/gvt: Use common error handling code in shadow_workload_ring_buffer() SF Markus Elfring
2017-10-24 12:52 ` Jani Nikula
2017-10-24 13:17 ` SF Markus Elfring [this message]
2017-10-24 13:54 ` Garry Hurley
2017-10-24 14:26 ` Dan Carpenter
2017-10-24 14:40 ` SF Markus Elfring
2017-10-24 14:42 ` Joe Perches
2017-10-24 14:51 ` SF Markus Elfring
2017-10-24 14:56 ` Joe Perches
2017-10-24 15:01 ` SF Markus Elfring
2017-10-24 15:14 ` Daniele Nicolodi
2017-10-24 18:56 ` [PATCH] " Wang, Zhi A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636f6272-9074-53dc-2c90-cbb4a7cd0901@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox