From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] hinic: uninitialized variable in hinic_api_cmd_init()
Date: Thu, 24 Aug 2017 12:24:55 +0000 [thread overview]
Message-ID: <63dafb26-dd90-bf64-bd41-48a844cdf924@huawei.com> (raw)
In-Reply-To: <20170824104739.gw422ufydwmiu4gi@mwanda>
On 8/24/2017 1:47 PM, Dan Carpenter wrote:
> We never set the error code in this function.
>
> Fixes: eabf0fad81d5 ("net-next/hinic: Initialize api cmd resources")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> index 8901801fe426..c40603a183df 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> @@ -941,6 +941,7 @@ int hinic_api_cmd_init(struct hinic_api_cmd_chain **chain,
> if (IS_ERR(chain[chain_type])) {
> dev_err(&pdev->dev, "Failed to create chain %d\n",
> chain_type);
> + err = PTR_ERR(chain[chain_type]);
> goto err_create_chain;
> }
> }
>
>
Thanks a lot, Reviewed-by: Aviad Krawczyk <aviad.krawczyk@huawei.com>
next prev parent reply other threads:[~2017-08-24 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 10:47 [PATCH net-next] hinic: uninitialized variable in hinic_api_cmd_init() Dan Carpenter
2017-08-24 12:24 ` Aviad Krawczyk [this message]
2017-08-25 4:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63dafb26-dd90-bf64-bd41-48a844cdf924@huawei.com \
--to=aviad.krawczyk@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox