Re: [PATCH][next] scsi: scsi_debug: make read-only arrays static const

["Colin King (gmail)" <colin.i.king@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1006 bytes --]

On 29/07/2025 18:45, Christophe JAILLET wrote:
> Le 29/07/2025 à 08:49, Colin Ian King a écrit :
>> Don't populate the read-only arrays on the stack at run time, instead
>> make them static const. Also reduces overall size.
>>
>> before:
>>     text       data        bss        dec        hex    filename
>>   367439      89582       5952     462973      7107d    drivers/scsi/ 
>> scsi_debug.o
>>
>> after:
>>     text       data        bss        dec        hex    filename
>>   365847      90702       5952     462501      70ea5    drivers/scsi/ 
>> scsi_debug.o
> 
> Hi,
> 
> out of curiosity, any idea why 'data' increase?

Because the arrays are being stored in the data section rather than on 
the stack.

> 
> All my constification patches lead to data reduction.
> 
>>
>> (gcc 14.2.0, x86-64)
> 
> (same kind of behavior with 15.1.1)
> 
> 
> CJ


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]