From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
netdev <netdev@vger.kernel.org>
Cc: Bhumika Goyal <bhumirks@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
David Windsor <dwindsor@gmail.com>,
Elena Reshetova <elena.reshetova@intel.com>,
Hans Liljestrand <ishkamiel@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Kees Cook <keescook@chromium.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] atm/clip: Use seq_puts() in svc_addr()
Date: Mon, 08 Jan 2018 07:25:16 +0000 [thread overview]
Message-ID: <66a18243-90fc-73c6-200a-fbbfa782d501@users.sourceforge.net> (raw)
In-Reply-To: <CAHp75Vf-fNi-ATKd-EpkO3HDP2TZCWFc6EEU5a5r-zkZTcHQYg@mail.gmail.com>
>> @@ -708,11 +708,11 @@ static void svc_addr(struct seq_file *seq, struct sockaddr_atmsvc *addr)
>> static int e164[] = { 1, 8, 4, 6, 1, 0 };
>>
>> if (*addr->sas_addr.pub) {
>> - seq_printf(seq, "%s", addr->sas_addr.pub);
>> + seq_puts(seq, addr->sas_addr.pub);
>
> Which opens a lot of security concerns.
How? - The passed string is just copied into a buffer finally, isn't it?
> Never do this again.
Why do you not like such a small source code transformation at the moment?
> P.S. I'm wondering what would be first,
I am curious on how communication difficulties can be adjusted.
> Markus starts looking into the actual code,
I inspected the original source code to some degree.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/seq_file.c?id‰5c0dde398510a5b5ded60e5064c11b94bd30ca#n682
https://elixir.free-electrons.com/linux/v4.15-rc6/source/fs/seq_file.c#L660
> or most (all) of the maintainers just ban him.
The change acceptance is varying for various reasons by the involved contributors.
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-08 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 21:44 [PATCH] atm/clip: Use seq_puts() in svc_addr() SF Markus Elfring
2018-01-06 22:25 ` Stefano Brivio
2018-01-07 8:19 ` SF Markus Elfring
2018-01-07 15:30 ` Stefano Brivio
2018-01-07 16:30 ` SF Markus Elfring
2018-01-07 22:58 ` [PATCH] " Andy Shevchenko
2018-01-08 7:25 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a18243-90fc-73c6-200a-fbbfa782d501@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=bhumirks@gmail.com \
--cc=davem@davemloft.net \
--cc=dwindsor@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=ishkamiel@gmail.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox