From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 24 Sep 2016 17:20:48 +0000 Subject: Re: Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() Message-Id: <69699b11-88fb-93ea-24a2-9ff697b5f439@users.sourceforge.net> List-Id: References: <1474733610.23838.2.camel@perches.com> <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net> <20160924163912.GA40187@dtor-ws> In-Reply-To: <20160924163912.GA40187@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dmitry Torokhov Cc: Joe Perches , linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall > The desired output should not be broken in conversion, which you did. I dared to change another source code place a bit too much perhaps. > Do you know how syslog works and why the transformation is not correct. I imagine that there are chances to improve the software situation a bit more, aren't there? > I am also curious as to why you are patching joydump? The discussed function implementation contains update candidates. One of them was detected by the execution of a script for the semantic patch language (Coccinelle software). I identified further update possibilities after the opportunity for using the function "kmalloc_array" also in this software module. > Are you working on extending it? I attempted just another software refactoring. Regards, Markus