Re: [RFC PATCH 1/1] MAINTAINERS: TTY LAYER: add some ./include/linux/ header files

Lukas Bulwahn
2021-05-23T07:06:02Z

On Tue, May 18, 2021 at 7:37 AM Jiri Slaby <jirislaby@kernel.org> wrote:
>
> On 18. 05. 21, 7:21, Lukas Bulwahn wrote:
> > An early prototypical automated code analysis of headers and the
> > existing MAINTAINERS sections identified some header files in
> > ./include/linux/ to be probably included into the TTY LAYER section.
> >
> > I further checked those suggestions by this analysis and identified a
> > subset of files that I am rather certain to belong to the TTY LAYER.
> >
> > Add these ./include/linux/ header files to TTY LAYER in MAINTAINERS.
> >
> > The patterns include/linux/tty*.h and include/linux/vt_*.h currently cover:
> >
> > include/linux/tty.h
> > include/linux/tty_driver.h
> > include/linux/tty_flip.h
> > include/linux/tty_ldisc.h
> >
> > include/linux/vt_buffer.h
> > include/linux/vt_kern.h
>
> Yes, that looks good.
>
> Can you extend the tool to include/uapi too?
>
> For example this is missing too:
> include/uapi/linux/tty*.h
>
> It expands to:
> include/uapi/linux/tty_flags.h
> include/uapi/linux/tty.h
>

Jiri,

Greg already picked this patch up; so I will keep this patch as-is and move on.

But I agree:
I am still tuning my script and that still needs a bit of work, so I
will still need some time until the next patches will follow.
Once I am happy with the script and I go back to manual checking,
review and adjustment of its output, I will follow your suggestion,
and prioritize to check that all additions for ./include/linux and
./include/uapi/linux are complete.
However, I will probably not come back to the TTY LAYER for a while
(until I can fully automate those patches with high confidence). The
patch for the next subsystem will probably be MEMORY MANAGEMENT or so,
depending if the manual checks and reviews show that the patches are
sufficiently good for that second try. I will come back to TTY LAYER,
once my method can assign all files in ./include sufficiently well to
its corresponding MAINTAINERS section; that will then be probably part
of a larger patch series for all MAINTAINERS sections and not just to
check the method for one or two sections.

Lukas