Re: [RFC PATCH 1/1] MAINTAINERS: TTY LAYER: add some ./include/linux/ header files

Greg Kroah-Hartman
2021-05-23T08:18:50Z

On Sun, May 23, 2021 at 09:05:48AM +0200, Lukas Bulwahn wrote:
> On Tue, May 18, 2021 at 7:37 AM Jiri Slaby <jirislaby@kernel.org> wrote:
> >
> > On 18. 05. 21, 7:21, Lukas Bulwahn wrote:
> > > An early prototypical automated code analysis of headers and the
> > > existing MAINTAINERS sections identified some header files in
> > > ./include/linux/ to be probably included into the TTY LAYER section.
> > >
> > > I further checked those suggestions by this analysis and identified a
> > > subset of files that I am rather certain to belong to the TTY LAYER.
> > >
> > > Add these ./include/linux/ header files to TTY LAYER in MAINTAINERS.
> > >
> > > The patterns include/linux/tty*.h and include/linux/vt_*.h currently cover:
> > >
> > > include/linux/tty.h
> > > include/linux/tty_driver.h
> > > include/linux/tty_flip.h
> > > include/linux/tty_ldisc.h
> > >
> > > include/linux/vt_buffer.h
> > > include/linux/vt_kern.h
> >
> > Yes, that looks good.
> >
> > Can you extend the tool to include/uapi too?
> >
> > For example this is missing too:
> > include/uapi/linux/tty*.h
> >
> > It expands to:
> > include/uapi/linux/tty_flags.h
> > include/uapi/linux/tty.h
> >
>
> Jiri,
>
> Greg already picked this patch up; so I will keep this patch as-is and move on.

This patch was fine as-is, but sending an additional patch with that
information added would be most welcome. No need for your tool to
create it, you can do it by hand :)

thanks,

greg k-h