From mboxrd@z Thu Jan 1 00:00:00 1970 From: haver Date: Mon, 08 Jan 2018 13:42:49 +0000 Subject: Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap() Message-Id: <6aa7eaf36fe5fff4849f4eec4d62051a@linux.vnet.ibm.com> List-Id: References: <127e28a8a4d9081eb323e3c7ab93dad0@linux.vnet.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , "Guilherme G. Piccoli" , LKML , =?UTF-8?Q?J=C3=B6rg-Stephan_Vogt?= , Michael Jung , =?UTF-8?Q?Michael_R=C3=BCttger?= On 2018-01-08 14:24, SF Markus Elfring wrote: >>> @@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, >>> struct >>> dma_mapping *m, void *uaddr, >>>                     sizeof(struct page *) + >>> sizeof(dma_addr_t), >>>                     GFP_KERNEL); >>>      if (!m->page_list) { >>> -        dev_err(&pci_dev->dev, "err: alloc page_list >>> failed\n"); >> >> Are there different printouts which cover this? > > Is this error message redundant? > > >> I mean the debug printout is not appearing all the time, >> it must be enabled, if I remember correctly. > > Would you like to clarify corresponding configuration possibilities any > more? > > >> So why do you suggest to remove it? > > Can the Linux allocation failure report be sufficient for this use case > already? > > Regards, > Markus According to Dans message in parallel, it should be redundant and I am fine with removing it. Acked-by: Frank Haverkamp