From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dominique Martinet <asmadeus@codewreck.org>,
kernel-janitors@vger.kernel.org
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
"Gilles Muller" <Gilles.Muller@lip6.fr>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Michal Marek" <michal.lkml@markovi.net>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [v3] Coccinelle: suggest replacing strncpy+truncation by strscpy
Date: Fri, 20 Jul 2018 09:40:30 +0000 [thread overview]
Message-ID: <6c657df2-a524-df22-eceb-6237cb5a9faa@users.sourceforge.net> (raw)
In-Reply-To: <1532047018-23754-1-git-send-email-asmadeus@codewreck.org>
> I didn't move all virtuals in a single line because none of the other
> kernel patch do it,
It can be occasionally useful to preserve another bit of coding tradition.
I dared to propose the reconsideration of such an implementation detail.
> and still do not see any advantage of moving the string to not use a variable
> so kept that as well.
I am curious if other software developers (besides me) would like to achieve
more source code reduction according to the principle “Don't repeat yourself”.
> This should hopefully be the last version :)
* Do any related development concerns need further safety checks for this
evolving source code transformation pattern?
* Julia Lawall has presented additional development ideas today.
https://lore.kernel.org/lkml/alpine.DEB.2.20.1807200759230.2349@hadrien/
https://lkml.org/lkml/2018/7/20/71
Regards,
Markus
next parent reply other threads:[~2018-07-20 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1532047018-23754-1-git-send-email-asmadeus@codewreck.org>
2018-07-20 9:40 ` SF Markus Elfring [this message]
[not found] <alpine.DEB.2.20.1807200745400.2349@hadrien>
2018-07-20 11:00 ` [v3] Coccinelle: suggest replacing strncpy+truncation by strscpy SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c657df2-a524-df22-eceb-6237cb5a9faa@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Gilles.Muller@lip6.fr \
--cc=asmadeus@codewreck.org \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=ville.syrjala@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox