From: Markus Elfring <Markus.Elfring@web.de>
To: Shuhao Fu <sfual@cse.ust.hk>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Cc: Bharath SM <bharathsm@microsoft.com>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Steve French <sfrench@samba.org>,
Steve French <smfrench@gmail.com>, Tom Talpey <tom@talpey.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] smb: Fix refcount leak for cifs_sb_tlink
Date: Wed, 15 Oct 2025 18:25:00 +0200 [thread overview]
Message-ID: <6eeec2b6-ef28-4280-a854-cc22d2df55ed@web.de> (raw)
In-Reply-To: <aO/DLq/OtAjvkgcY@chcpu18>
> Fix three refcount inconsistency issues related to `cifs_sb_tlink`.
I suggest to omit this introduction.
> Comments for `cifs_sb_tlink` state that `cifs_put_tlink()` needs to be
()?
> called after successful calls to `cifs_sb_tlink`. Three callsites fail
call sites?
> to update refcount accordingly, leading to possible resource leaks.
* Do we prefer the term “reference count”?
* Is the word “possible” really relevant here?
(Would you find corresponding case distinctions more helpful?)
* How do you think about to increase the application of scope-based resource management?
Regards,
Markus
next prev parent reply other threads:[~2025-10-15 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aOzRF9JB9VkBKapw@osx.local>
2025-10-15 14:52 ` [PATCH] smb: Fix refcount leak for cifs_sb_tlink Markus Elfring
2025-10-15 15:52 ` Shuhao Fu
2025-10-15 16:25 ` Markus Elfring [this message]
2025-10-15 18:10 ` Steve French
2025-10-15 16:29 ` Steve French
2025-10-16 2:59 ` Shuhao Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eeec2b6-ef28-4280-a854-cc22d2df55ed@web.de \
--to=markus.elfring@web.de \
--cc=bharathsm@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sfual@cse.ust.hk \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox