From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Date: Wed, 26 Jun 2019 14:56:42 +0000 Subject: Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index Message-Id: <712efbc2-1c10-8e6e-7517-16fa57cb8709@canonical.com> List-Id: References: <20190511132700.4862-1-colin.king@canonical.com> <20190521150311.GL31203@kadam> <20190626061801.GA18776@kadam> In-Reply-To: <20190626061801.GA18776@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Mike Marshall Cc: linux-fsdevel , Martin Brandenburg , devel@lists.orangefs.org, kernel-janitors@vger.kernel.org, LKML On 26/06/2019 07:18, Dan Carpenter wrote: > On Tue, Jun 25, 2019 at 02:55:11PM -0400, Mike Marshall wrote: >>>> You often send these patches before they hit linux-next so I had skipped >>>> reviewing this one when you sent it. >> >> I know Linus is likely to refuse pull requests for stuff that >> has not been through linux-next, so I make sure stuff has been >> there at least a few days before asking for it to be pulled. >> "A few days" is long enough for robots to see it, perhaps not >> long enough for humans. I especially appreciate the human review. One of >> the good things about Orangefs is that it is easy to install and configure, >> especially for testing. Documentation/filesystems/orangefs.txt has >> instructions for dnf installing orangefs on Fedora, and also how to download >> a source tarball and install from that. > > No, no, that comment was to Colin. It's good that he's sending patches > for all the trees as soon as possible like the zero day bot does. But > it does make it hard to review at times. > > regards, > dan carpenter > Indeed, I normally work against the latest code landing in linux-next, so apologies for any confusion. Anyhow, by the look of it these minor nitpicks still need addressing (really low priority), so shall I leave that with you Mike to sort out? Colin