From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/i915/selftest: Fix an error code in live_noa_gpr()
Date: Tue, 14 Jul 2020 14:16:33 +0000 [thread overview]
Message-ID: <71508ba9-6cad-45f9-a3b1-b3401ac0a1d5@intel.com> (raw)
In-Reply-To: <20200714141216.GA314989@mwanda>
On 14/07/2020 17:12, Dan Carpenter wrote:
> The error code is not set on this error path. It's either zero or
> uninitialized at this point.
>
> Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c
> index deb6dec1b5ab..7aa73bb03381 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_perf.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c
> @@ -329,6 +329,7 @@ static int live_noa_gpr(void *arg)
> cs = intel_ring_begin(rq, 2 * 32 + 2);
> if (IS_ERR(cs)) {
> i915_request_add(rq);
> + err = PTR_ERR(cs);
> goto out_rq;
> }
>
Looks like there is another below :
cs = intel_ring_begin(rq, 4);
if (IS_ERR(cs)) {
i915_request_add(rq);
goto out_rq;
}
-Lionel
next prev parent reply other threads:[~2020-07-14 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:12 [PATCH] drm/i915/selftest: Fix an error code in live_noa_gpr() Dan Carpenter
2020-07-14 14:16 ` Lionel Landwerlin [this message]
2020-07-14 14:31 ` Dan Carpenter
2020-07-14 14:36 ` [PATCH v2] " Dan Carpenter
2020-07-14 14:39 ` Lionel Landwerlin
2020-07-14 17:15 ` [Intel-gfx] " Chris Wilson
2020-07-14 18:08 ` Dan Carpenter
2020-07-14 18:12 ` Colin Ian King
2021-02-15 15:58 ` [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71508ba9-6cad-45f9-a3b1-b3401ac0a1d5@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox