public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Joe Perches <joe@perches.com>
Cc: linux-mips@linux-mips.org,
	"Dan Carpenter" <dan.carpenter@oracle.com>,
	"David Daney" <david.daney@cavium.com>,
	"Ralf Bächle" <ralf@linux-mips.org>,
	"Steven J. Hill" <steven.hill@cavium.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_
Date: Wed, 24 May 2017 16:01:39 +0000	[thread overview]
Message-ID: <71a2ce6a-968c-b13c-95b0-610f0c1bab03@users.sourceforge.net> (raw)
In-Reply-To: <1495565752.2093.69.camel@perches.com>

>> +++ b/arch/mips/cavium-octeon/octeon-irq.c
>> @@ -1615,7 +1615,6 @@ static int __init octeon_irq_init_gpio(
>>  		irq_domain_add_linear(
>>  			gpio_node, 16, &octeon_irq_domain_gpio_ops, gpiod);
>>  	} else {
>> -		pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
>>  		return -ENOMEM;
>>  	}
> 
> You really should reverse the test here and
> unindent the first block.

Thanks for your improved source code transformation.

I am curious if I will stumble on a similar change possibility once more
for remaining update candidates in other software areas.

Regards,
Markus

  parent reply	other threads:[~2017-05-24 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 18:10 [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_gpio SF Markus Elfring
2017-05-23 18:55 ` [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_ Joe Perches
2017-05-23 18:59   ` David Daney
2017-05-23 21:42   ` David Daney
2017-05-24 16:01   ` SF Markus Elfring [this message]
2017-05-24 19:43     ` Joe Perches
2017-05-29 19:38       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71a2ce6a-968c-b13c-95b0-610f0c1bab03@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=dan.carpenter@oracle.com \
    --cc=david.daney@cavium.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=steven.hill@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox