From: Jens Axboe <axboe@kernel.dk>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-block@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: blk-throttle: Move three assignments for the variable "ret" in tg_set_max()
Date: Mon, 23 Jan 2017 15:17:24 +0000 [thread overview]
Message-ID: <736ca444-0157-4dbb-ef30-e59b36596c1f@kernel.dk> (raw)
In-Reply-To: <849a1dbc-f4c0-caf0-ad7e-706c08127c68@users.sourceforge.net>
On 01/23/2017 05:06 AM, SF Markus Elfring wrote:
>>> We have got different preferences for the placement of error code settings.
>> Yes we do, so what's the point? Both are OK.
>
> Can a function implementation be executed a bit faster in the case
> that error codes will usually only matter if they would be set after
> a concrete software failure
Don't turn this into a troll fest. Maintainability trumps performance.
Every time. See previous email for reasoning for that.
>> Please don't go down that road it opens so much potential for needless bikeshedding
>> and waste all of our (including your) time.
>
> I would appreciate to clarify involved run time consequences a bit more.
How about you go and benchmark the before and after, and present some
compelling evidence based on those tests for why the change should be
made? The onus is on the submitter here, not the reviewer.
As I said in the previous email, don't bother sending these types of
patches for the block layer again. They are just going to be ignored.
--
Jens Axboe
next prev parent reply other threads:[~2017-01-23 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 8:30 [PATCH 0/5] block: Fine-tuning for five function implementations SF Markus Elfring
2017-01-22 8:31 ` [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max() SF Markus Elfring
2017-01-23 9:15 ` Johannes Thumshirn
2017-01-23 10:00 ` SF Markus Elfring
2017-01-23 11:47 ` Johannes Thumshirn
2017-01-23 12:06 ` SF Markus Elfring
2017-01-23 15:17 ` Jens Axboe [this message]
2017-01-22 8:32 ` [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf() SF Markus Elfring
2017-01-23 9:16 ` Johannes Thumshirn
2017-01-22 8:33 ` [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment SF Markus Elfring
2017-01-23 9:20 ` Johannes Thumshirn
2017-01-23 15:14 ` Jens Axboe
2017-01-22 8:34 ` [PATCH 4/5] cfq-iosched: Move an assignment for the variable "ret" in __cfqg_set_weight_device() SF Markus Elfring
2017-01-22 8:35 ` [PATCH 5/5] cfq-iosched: Adjust one function call together with a variable assignment SF Markus Elfring
2017-01-23 9:21 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=736ca444-0157-4dbb-ef30-e59b36596c1f@kernel.dk \
--to=axboe@kernel.dk \
--cc=elfring@users.sourceforge.net \
--cc=jthumshirn@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox