From: Neil Armstrong <narmstrong@baylibre.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Archit Taneja <architt@codeaurora.org>
Cc: David Airlie <airlied@linux.ie>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
Date: Thu, 06 Apr 2017 07:41:22 +0000 [thread overview]
Message-ID: <757bc9ac-9e17-cd19-e805-5fa4a19d225b@baylibre.com> (raw)
In-Reply-To: <20170406052132.GA26605@mwanda>
On 04/06/2017 07:21 AM, Dan Carpenter wrote:
> There was supposed to be a break before the next case statement.
>
> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 84cc949eae2b..8b605039c613 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
> frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
> frame.extended_colorimetry > HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> + break;
> case V4L2_YCBCR_ENC_709:
> if (hdmi->hdmi_data.enc_in_encoding = V4L2_YCBCR_ENC_XV709)
> frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
>
Thanks for the fix !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2017-04-06 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 5:21 [PATCH] drm: bridge: dw-hdmi: Add a missing break statement Dan Carpenter
2017-04-06 7:41 ` Neil Armstrong [this message]
2017-04-06 8:58 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757bc9ac-9e17-cd19-e805-5fa4a19d225b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox