From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Date: Thu, 06 Apr 2017 07:41:22 +0000 Subject: Re: [PATCH] drm: bridge: dw-hdmi: Add a missing break statement Message-Id: <757bc9ac-9e17-cd19-e805-5fa4a19d225b@baylibre.com> List-Id: References: <20170406052132.GA26605@mwanda> In-Reply-To: <20170406052132.GA26605@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Archit Taneja Cc: David Airlie , Laurent Pinchart , Jose Abreu , Daniel Vetter , Kieran Bingham , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org On 04/06/2017 07:21 AM, Dan Carpenter wrote: > There was supposed to be a break before the next case statement. > > Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 84cc949eae2b..8b605039c613 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) > frame.colorimetry = HDMI_COLORIMETRY_ITU_601; > frame.extended_colorimetry > HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; > + break; > case V4L2_YCBCR_ENC_709: > if (hdmi->hdmi_data.enc_in_encoding = V4L2_YCBCR_ENC_XV709) > frame.colorimetry = HDMI_COLORIMETRY_EXTENDED; > Thanks for the fix ! Acked-by: Neil Armstrong