Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

SF Markus Elfring
2017-09-26T16:50:29Z

>> @@ -129,18 +129,18 @@ static int tda8261_set_params(struct dvb_frontend *fe)
>>
>> /* Set params */
>> err = tda8261_write(state, buf);
>> - if (err < 0) {
>> - pr_err("%s: I/O Error\n", __func__);
>> - return err;
>> - }
>> + err = tda8261_get_status(fe, &status);
>> + if (err < 0)
>> + goto report_failure;
>> +
>
> Is this change really correct? Doesn't it query the status once more
> often than before?

Thanks for your inquiry.

Unfortunately, I made a copy mistake at this source code place.
When should I send a corrected suggestion for this update step
in the patch series?

Regards,
Markus