From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Christoph Böhmwalder" <christoph@boehmwalder.at>,
linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Max Kellermann <max.kellermann@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()
Date: Tue, 26 Sep 2017 16:50:29 +0000 [thread overview]
Message-ID: <792ce307-e8a1-8159-c601-f3188fa82226@users.sourceforge.net> (raw)
In-Reply-To: <bcf8d922-fde7-59a0-f3d9-3f16a2a62d9b@boehmwalder.at>
>> @@ -129,18 +129,18 @@ static int tda8261_set_params(struct dvb_frontend *fe)
>>
>> /* Set params */
>> err = tda8261_write(state, buf);
>> - if (err < 0) {
>> - pr_err("%s: I/O Error\n", __func__);
>> - return err;
>> - }
>> + err = tda8261_get_status(fe, &status);
>> + if (err < 0)
>> + goto report_failure;
>> +
>
> Is this change really correct? Doesn't it query the status once more
> often than before?
Thanks for your inquiry.
Unfortunately, I made a copy mistake at this source code place.
When should I send a corrected suggestion for this update step
in the patch series?
Regards,
Markus
next prev parent reply other threads:[~2017-09-26 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 11:26 [PATCH 0/6] [media] TDA8261: Fine-tuning for five function implementations SF Markus Elfring
2017-09-26 11:27 ` [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params() SF Markus Elfring
2017-09-26 11:45 ` Christoph Böhmwalder
2017-09-26 16:50 ` SF Markus Elfring [this message]
2017-09-26 11:28 ` [PATCH 2/6] [media] tda8261: Improve a size determination in tda8261_attach() SF Markus Elfring
2017-09-26 11:30 ` [PATCH 3/6] [media] tda8261: Return directly after a failed kzalloc() " SF Markus Elfring
2017-09-26 11:32 ` [PATCH 4/6] [media] tda8261: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-09-26 11:33 ` [PATCH 5/6] [media] tda8261: Adjust three function calls together with a variable assignment SF Markus Elfring
2017-09-26 11:34 ` [PATCH 6/6] [media] tda8261: Delete an unnecessary variable initialisation in three functions SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=792ce307-e8a1-8159-c601-f3188fa82226@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=christoph@boehmwalder.at \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox