From mboxrd@z Thu Jan  1 00:00:00 1970
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 18:15:14 +0000
Subject: Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_pro
Message-Id: <796029e7-60a3-a94b-8b5c-4686a0656560@users.sourceforge.net>
List-Id: <kernel-janitors.vger.kernel.org>
References: <6ebb5193-239f-5c34-c5f6-2be8a2fa79a5@users.sourceforge.net>
 <CAOLZvyHq-7q0XxiBsyX3q0g0J3kjfFv4SU7amX1hpjRDyK+feQ@mail.gmail.com>
In-Reply-To: <CAOLZvyHq-7q0XxiBsyX3q0g0J3kjfFv4SU7amX1hpjRDyK+feQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Manuel Lauss <manuel.lauss@gmail.com>, linux-mips@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>, =?UTF-8?Q?Ralf_B=c3=a4chle?= <ralf@linux-mips.org>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org

>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>
>>         ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>>         if (!ctx) {
>> -               dev_err(&pdev->dev, "no memory for pcictl context\n");
>>                 ret = -ENOMEM;
>>                 goto out;
>>         }
>> --
>> 2.13.0
> 
> Why are you removing just this one dev_err()?

How do you think about to achieve a small code reduction also for this software module?


> What issue are you trying to address?

Do you find information from a Linux allocation failure report sufficient
for such a function implementation?

Regards,
Markus