From: Vasant Hegde <vasant.hegde@amd.com>
To: "Markus Elfring" <Markus.Elfring@web.de>,
"Can Peng" <pengcan@kylinos.cn>,
iommu@lists.linux.dev, cocci@inria.fr,
"Jörg Rödel" <joro@8bytes.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Will Deacon" <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] iommu: simplify list initialization in iommu_create_device_direct_mappings() and iommu_group_show_resv_regions()
Date: Tue, 13 Jan 2026 15:34:57 +0530 [thread overview]
Message-ID: <7d25b66c-069f-46a3-9bb8-e6732745ab75@amd.com> (raw)
In-Reply-To: <34ed442d-6ebd-4907-a77c-2c08db799411@web.de>
On 1/12/2026 6:00 PM, Markus Elfring wrote:
>> Changes since v1:
>> - Extend the cleanup to iommu_group_show_resv_regions() as suggested by
>> reviewer, applying the same LIST_HEAD() pattern consistently across
>> the file.
>
> Thanks for your interest in further code adjustments.
>
> * I wonder how they fit to the feedback “Applied, thanks.” by Jörg Rödel
> from 2026-01-10.
> https://lore.kernel.org/lkml/stpavkxy3sbevk7zmt4kxyecqy5gc6phubvcfutbtnuk7vphlh@a7aimtvk423i/
> https://lkml.org/lkml/2026/1/10/235
Right. Patch is already applied. @Can, Please rebase patch on top of iommu/next
branch.
>
> * A shorter summary phrase might become more desirable for this patch variant.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n687
>
> * Will development interests grow also for another transformation approach
> like the following by the means of the semantic patch language (Coccinelle software)?
>
>
> @replacement@
> expression e;
> identifier i;
> @@
> -struct list_head i;
> ... when exists
> when != i = e
> -INIT_LIST_HEAD
> +LIST_HEAD
> (
> - &
> i
> );
>
>
> I determined that 175 source files of the software “Linux next-20260109” contain
> corresponding update candidates.
Interesting! Thanks for the stat.
-Vasant
prev parent reply other threads:[~2026-01-13 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260112032116.49781-1-pengcan@kylinos.cn>
2026-01-12 12:30 ` [PATCH v2] iommu: simplify list initialization in iommu_create_device_direct_mappings() and iommu_group_show_resv_regions() Markus Elfring
2026-01-13 10:04 ` Vasant Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d25b66c-069f-46a3-9bb8-e6732745ab75@amd.com \
--to=vasant.hegde@amd.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@inria.fr \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengcan@kylinos.cn \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox