From: Colin Ian King <colin.king@canonical.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Marc Zyngier" <maz@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] PCI: apple: Remove redundant initialization of pointer port_pdev
Date: Wed, 13 Oct 2021 15:22:22 +0100 [thread overview]
Message-ID: <7fb08233-efc9-b0bd-b234-084e52878036@canonical.com> (raw)
In-Reply-To: <20211013134114.GC11036@lpieralisi>
On 13/10/2021 14:41, Lorenzo Pieralisi wrote:
> On Tue, Oct 12, 2021 at 02:32:35PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer port_pdev is being initialized with a value that is never
>> read, it is being updated later on. The assignment is redundant and
>> can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/pci/controller/pcie-apple.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Squashed into the commit it is fixing.
>
Thanks. Much appreciated.
> Thanks !
> Lorenzo
>
>> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
>> index b4db7a065553..19fd2d38aaab 100644
>> --- a/drivers/pci/controller/pcie-apple.c
>> +++ b/drivers/pci/controller/pcie-apple.c
>> @@ -634,7 +634,7 @@ static struct apple_pcie_port *apple_pcie_get_port(struct pci_dev *pdev)
>> {
>> struct pci_config_window *cfg = pdev->sysdata;
>> struct apple_pcie *pcie = cfg->priv;
>> - struct pci_dev *port_pdev = pdev;
>> + struct pci_dev *port_pdev;
>> struct apple_pcie_port *port;
>>
>> /* Find the root port this device is on */
>> --
>> 2.32.0
>>
prev parent reply other threads:[~2021-10-13 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 13:32 [PATCH][next] PCI: apple: Remove redundant initialization of pointer port_pdev Colin King
2021-10-12 15:02 ` Alyssa Rosenzweig
2021-10-13 0:47 ` Krzysztof Wilczyński
2021-10-13 13:41 ` Lorenzo Pieralisi
2021-10-13 14:06 ` Alyssa Rosenzweig
2021-10-13 14:14 ` Lorenzo Pieralisi
2021-10-13 14:22 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fb08233-efc9-b0bd-b234-084e52878036@canonical.com \
--to=colin.king@canonical.com \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox