* [PATCH] fbdev: omapfb: off by one in omapfb_register_client()
@ 2018-07-13 14:55 ` Dan Carpenter
2018-07-13 15:05 ` Dan Carpenter
2018-07-24 16:48 ` Bartlomiej Zolnierkiewicz
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-07-13 14:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Imre Deak
Cc: linux-fbdev, linux-omap, kernel-janitors, dri-devel
The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the
> should be >= or we are one element beyond the end of the array.
Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 585f39efcff6..1c75f4806ed3 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -958,7 +958,7 @@ int omapfb_register_client(struct omapfb_notifier_block *omapfb_nb,
{
int r;
- if ((unsigned)omapfb_nb->plane_idx > OMAPFB_PLANE_NUM)
+ if ((unsigned)omapfb_nb->plane_idx >= OMAPFB_PLANE_NUM)
return -EINVAL;
if (!notifier_inited) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] fbdev: omapfb: off by one in omapfb_register_client()
2018-07-13 14:55 ` [PATCH] fbdev: omapfb: off by one in omapfb_register_client() Dan Carpenter
@ 2018-07-13 15:05 ` Dan Carpenter
2018-07-24 16:48 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-07-13 15:05 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Imre Deak
Cc: linux-fbdev, linux-omap, kernel-janitors, dri-devel
The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the
> should be >= or we are one element beyond the end of the array.
Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 585f39efcff6..1c75f4806ed3 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -958,7 +958,7 @@ int omapfb_register_client(struct omapfb_notifier_block *omapfb_nb,
{
int r;
- if ((unsigned)omapfb_nb->plane_idx > OMAPFB_PLANE_NUM)
+ if ((unsigned)omapfb_nb->plane_idx >= OMAPFB_PLANE_NUM)
return -EINVAL;
if (!notifier_inited) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev: omapfb: off by one in omapfb_register_client()
2018-07-13 14:55 ` [PATCH] fbdev: omapfb: off by one in omapfb_register_client() Dan Carpenter
2018-07-13 15:05 ` Dan Carpenter
@ 2018-07-24 16:48 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-07-24 16:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: linux-fbdev, Imre Deak, kernel-janitors, dri-devel, linux-omap
On Friday, July 13, 2018 05:55:55 PM Dan Carpenter wrote:
> The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the
> > should be >= or we are one element beyond the end of the array.
>
> Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-24 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180713145615epcas3p4e584128beb220b339552ad92fe2eb3b4@epcas3p4.samsung.com>
2018-07-13 14:55 ` [PATCH] fbdev: omapfb: off by one in omapfb_register_client() Dan Carpenter
2018-07-13 15:05 ` Dan Carpenter
2018-07-24 16:48 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox