[PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

[PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

[Christophe JAILLET]

This serie aims to fix 2 issues. (path 2 & 4)

The 2nd patch fixes a memory leak. It uses devm_ function a simplify the
handling of the memory.

The 4th patch fixes a potential invalid pointer dereference.

The 2 other ones, are just clean-ups to remove useless code and add other
uses of devm_ function to simplify code.

I've left the request_irq/free_irq because I'm unsure of potential side
effects if some other resources are freed while an IRQ can still be
triggered. So I've preferred to leave it as-is.

Christophe JAILLET (4):
  usb: gadget: fotg210-udc: Remove a useless
  usb: gadget: fotg210-udc: Fix a memory leak
  usb: gadget: fotg210-udc: Simplify code
  usb: gadget: fotg210-udc: Fix a potential invalid pointer dereference

 drivers/usb/gadget/udc/fotg210-udc.c | 41 ++++++++++++------------------------
 1 file changed, 14 insertions(+), 27 deletions(-)

-- 
2.14.1

Re: [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]


Hi,

Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> This serie aims to fix 2 issues. (path 2 & 4)
>
> The 2nd patch fixes a memory leak. It uses devm_ function a simplify the
> handling of the memory.
>
> The 4th patch fixes a potential invalid pointer dereference.
>
> The 2 other ones, are just clean-ups to remove useless code and add other
> uses of devm_ function to simplify code.
>
> I've left the request_irq/free_irq because I'm unsure of potential side
> effects if some other resources are freed while an IRQ can still be
> triggered. So I've preferred to leave it as-is.
>
> Christophe JAILLET (4):
>   usb: gadget: fotg210-udc: Remove a useless
>   usb: gadget: fotg210-udc: Fix a memory leak
>   usb: gadget: fotg210-udc: Simplify code
>   usb: gadget: fotg210-udc: Fix a potential invalid pointer dereference

you should NEVER make fixes depend on cleanups. It should be the other
way around :-) First fixes, then cleanups. The reason is that fixes can
get accepted during -rc cycle, but cleanups must wait until the next
merge window.

Please fix up your patches, otherwise I'll have to apply the entire
series for v4.17

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

[Hans Ulli Kroll]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 950 bytes --]

Hi Christophe

On Mon, 12 Feb 2018, Christophe Jaillet wrote:

> Le 12/02/2018 à 09:48, Felipe Balbi a écrit :
> > 
[..]

> > way around :-) First fixes, then cleanups. The reason is that fixes can
> > get accepted during -rc cycle, but cleanups must wait until the next
> > merge window.
> > 
> > Please fix up your patches, otherwise I'll have to apply the entire
> > series for v4.17
> > 
> 
> I agree with you. I will be more careful in the future.
> However, I will not re-send an updated version. Development on this driver
> does not seem to be very active.

... not quite right.
This driver and the fotg210-hcd is *currently* under my observation, I 
want to add a phy/otg driber on top of these.
Feel free to CC me if you want to resend these patches.

With "not very active" makes me happy, so I don't break not much.
And if anyone ask, I have some devices to test, of cource ;-)

Greetings
Hans Ulli Kroll