* [PATCH] serial: omap-serial: fix signess error
@ 2010-10-10 17:28 Vasiliy Kulikov
2010-10-12 18:02 ` Greg KH
2010-10-12 18:39 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Vasiliy Kulikov @ 2010-10-10 17:28 UTC (permalink / raw)
To: kernel-janitors
Cc: Govindraj.R, Greg Kroah-Hartman, Kevin Hilman, Alan Cox,
linux-kernel
"ret" is unsigned, so check for (ret < 0) made no sense.
Made it signed.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
I cannot compile this driver, so it is not tested.
drivers/serial/omap-serial.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c
index 2ee1d32..14365f7 100644
--- a/drivers/serial/omap-serial.c
+++ b/drivers/serial/omap-serial.c
@@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no)
{
struct uart_omap_port *up = ui[uart_no];
unsigned int curr_dma_pos, curr_transmitted_size;
- unsigned int ret = 0;
+ int ret = 0;
curr_dma_pos = omap_get_dma_dst_pos(up->uart_dma.rx_dma_channel);
if ((curr_dma_pos = up->uart_dma.prev_rx_dma_pos) ||
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] serial: omap-serial: fix signess error
2010-10-10 17:28 [PATCH] serial: omap-serial: fix signess error Vasiliy Kulikov
@ 2010-10-12 18:02 ` Greg KH
2010-10-12 18:39 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2010-10-12 18:02 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: kernel-janitors, Govindraj.R, Greg Kroah-Hartman, Kevin Hilman,
Alan Cox, linux-kernel
On Sun, Oct 10, 2010 at 09:28:35PM +0400, Vasiliy Kulikov wrote:
> "ret" is unsigned, so check for (ret < 0) made no sense.
> Made it signed.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> I cannot compile this driver, so it is not tested.
>
> drivers/serial/omap-serial.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
This seems to be in the omap tree, and not in my tree, so you will need
to push this through the omap maintainers.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: omap-serial: fix signess error
2010-10-10 17:28 [PATCH] serial: omap-serial: fix signess error Vasiliy Kulikov
2010-10-12 18:02 ` Greg KH
@ 2010-10-12 18:39 ` Kevin Hilman
2010-10-12 20:21 ` Tony Lindgren
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2010-10-12 18:39 UTC (permalink / raw)
To: Vasiliy Kulikov, Tony Lindgren
Cc: kernel-janitors, Govindraj.R, Greg Kroah-Hartman, Alan Cox,
linux-kernel, linux-omap
[adding linux-omap list]
Vasiliy Kulikov <segooon@gmail.com> writes:
> "ret" is unsigned, so check for (ret < 0) made no sense.
> Made it signed.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> I cannot compile this driver, so it is not tested.
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
Since the original driver is being queued via the omap tree, we can
queue this one as well.
Tony, can you add this one to the 2.6.37 queue?
Thanks,
Kevin
> drivers/serial/omap-serial.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c
> index 2ee1d32..14365f7 100644
> --- a/drivers/serial/omap-serial.c
> +++ b/drivers/serial/omap-serial.c
> @@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no)
> {
> struct uart_omap_port *up = ui[uart_no];
> unsigned int curr_dma_pos, curr_transmitted_size;
> - unsigned int ret = 0;
> + int ret = 0;
>
> curr_dma_pos = omap_get_dma_dst_pos(up->uart_dma.rx_dma_channel);
> if ((curr_dma_pos = up->uart_dma.prev_rx_dma_pos) ||
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] serial: omap-serial: fix signess error
2010-10-12 18:39 ` Kevin Hilman
@ 2010-10-12 20:21 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2010-10-12 20:21 UTC (permalink / raw)
To: Kevin Hilman
Cc: Vasiliy Kulikov, kernel-janitors, Govindraj.R, Greg Kroah-Hartman,
Alan Cox, linux-kernel, linux-omap
* Kevin Hilman <khilman@deeprootsystems.com> [101012 11:30]:
> [adding linux-omap list]
>
> Vasiliy Kulikov <segooon@gmail.com> writes:
>
> > "ret" is unsigned, so check for (ret < 0) made no sense.
> > Made it signed.
> >
> > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> > ---
> > I cannot compile this driver, so it is not tested.
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> Since the original driver is being queued via the omap tree, we can
> queue this one as well.
>
> Tony, can you add this one to the 2.6.37 queue?
Thanks, adding into omap-for-linus.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-12 20:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-10 17:28 [PATCH] serial: omap-serial: fix signess error Vasiliy Kulikov
2010-10-12 18:02 ` Greg KH
2010-10-12 18:39 ` Kevin Hilman
2010-10-12 20:21 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).