* [PATCH] ALSA: oss: delete self assignment
@ 2026-02-06 13:41 Dan Carpenter
2026-02-06 13:45 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2026-02-06 13:41 UTC (permalink / raw)
To: Takashi Iwai
Cc: Jaroslav Kysela, Thorsten Blum, linux-sound, linux-kernel,
kernel-janitors
No need to assign "uctl" to itself. Delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
sound/core/oss/mixer_oss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index 69422ab2d808..8d2d46d03301 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -792,7 +792,7 @@ static int snd_mixer_oss_get_recsrc2(struct snd_mixer_oss_file *fmixer, unsigned
struct snd_ctl_elem_info *uinfo __free(kfree) =
kzalloc(sizeof(*uinfo), GFP_KERNEL);
struct snd_ctl_elem_value *uctl __free(kfree) =
- uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
+ kzalloc(sizeof(*uctl), GFP_KERNEL);
if (uinfo == NULL || uctl == NULL)
return -ENOMEM;
guard(rwsem_read)(&card->controls_rwsem);
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: oss: delete self assignment
2026-02-06 13:41 [PATCH] ALSA: oss: delete self assignment Dan Carpenter
@ 2026-02-06 13:45 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-02-06 13:45 UTC (permalink / raw)
To: Dan Carpenter
Cc: Takashi Iwai, Jaroslav Kysela, Thorsten Blum, linux-sound,
linux-kernel, kernel-janitors
On Fri, 06 Feb 2026 14:41:47 +0100,
Dan Carpenter wrote:
>
> No need to assign "uctl" to itself. Delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks, it's a garbage at the previous fix commit 55f98ece9939 ("ALSA:
oss: Relax __free() variable declarations"). So I applied with a
Fixes tag.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-06 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 13:41 [PATCH] ALSA: oss: delete self assignment Dan Carpenter
2026-02-06 13:45 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox