From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Date: Fri, 10 Feb 2012 20:58:16 +0000 Subject: Re: [PATCH v2] scripts/coccinelle/misc/boolinit.cocci: semantic patch for bool issues Message-Id: <874nuye7aa.fsf@rustcorp.com.au> List-Id: References: <1328905355-30874-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1328905355-30874-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , Julia Lawall Cc: kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , cocci@diku.dk, linux-kernel@vger.kernel.org, Michal Marek , bruce.w.allan@intel.com, joe@perches.com On Fri, 10 Feb 2012 21:22:35 +0100, Julia Lawall wrote: > From: Julia Lawall > > Signed-off-by: Julia Lawall FWIW: Reviewed-by: Rusty Russell > +coccilib.report.print_report(p2[0],"WARNING: Assignment of bool to non-0/1 constant") IMHO, this one should be an error! Thanks, Rusty.