From: Robert Jarzmik <robert.jarzmik@free.fr>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] gpio: pxa: fix potential NULL dereference in pxa_gpio_probe()
Date: Wed, 11 Jul 2018 19:59:32 +0000 [thread overview]
Message-ID: <87601lfsrf.fsf@belgarion.home> (raw)
In-Reply-To: <1531315178-185878-1-git-send-email-weiyongjun1@huawei.com>
Wei Yongjun <weiyongjun1@huawei.com> writes:
> platform_get_resource() may fail and return NULL, so we should
> better check it's return value to avoid a NULL pointer dereference
> a bit later in the code.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = platform_get_resource(pdev, t, n);
> + if (!res)
> + return -EINVAL;
> ... when != res = NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
next prev parent reply other threads:[~2018-07-11 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 13:19 [PATCH -next] gpio: pxa: fix potential NULL dereference in pxa_gpio_probe() Wei Yongjun
2018-07-11 19:59 ` Robert Jarzmik [this message]
2018-07-13 8:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87601lfsrf.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox