From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Fri, 05 May 2017 05:51:47 +0000 Subject: Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Message-Id: <8760hfyhos.fsf@intel.com> List-Id: References: <39c8a155-cf89-1aa5-9ca6-4e9ccf3aa602@users.sourceforge.net> <56ab5065-5a24-47cf-023f-b10c6daf4799@users.sourceforge.net> <20170504200928.GL24019@nuc-i3427.alporthouse.com> In-Reply-To: <20170504200928.GL24019@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chris Wilson , SF Markus Elfring Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Daniel Vetter On Thu, 04 May 2017, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Thu, 4 May 2017 13:20:47 +0200 >> >> Some strings which did not contain data format specifications should be put >> into a sequence. Thus use the corresponding function "seq_puts". > > debugfs / seq_file is not performance critical. Familiar idiomatic code is > much preferred over continually switching between seq_printf and seq_puts. > > And don't even start on converting seq_printf / seq_puts to seq_putc... Agreed. I don't want any of the seq_* changes in this series. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center