From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Fri, 05 Oct 2018 11:04:42 +0000 Subject: Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings Message-Id: <877eiw1wol.fsf@codeaurora.org> List-Id: References: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Fri, 5 Oct 2018 11:07:26 +0000") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Maya Erez , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org YueHaibing writes: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Just out of curiosity, what kind of overhead are we talking about here? -- Kalle Valo