From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E71DC7EE26 for ; Tue, 23 May 2023 10:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236249AbjEWKam (ORCPT ); Tue, 23 May 2023 06:30:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236041AbjEWKal (ORCPT ); Tue, 23 May 2023 06:30:41 -0400 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23555FD for ; Tue, 23 May 2023 03:30:40 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4f3b314b1d7so4230505e87.1 for ; Tue, 23 May 2023 03:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684837778; x=1687429778; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/T9opHzMSw2R0AZ40N9B37p3pMgsnkJKDx5J8AZzmBw=; b=tRCziY5FD1lkGf8nKeQnWUtC2+ERps6DDPpk5yUmC55lO42H5ojtarEofe+3Xcm6rP 2bjfgs8JMr68U5JjKwaCkXMaSWFL8LCooihu9NoITjoxZ9kN6KTw+Jdb9fz8NCY5H5Qy Gup1Tnx01gCFsPphfjbRg4/TJ8awUbbHTEbHchk3A+Nz4EBhFkgOEYUo23fnR7kH/2Yw 1mPYJSAx77KMtXmkTcPX9tR/nbVjhbcTYHpL1YTHQQGiuc0SqyU1Jc69dmPjBZsw5M75 7AwwsfE5NOWtWBw9HcnUPDCBj6ubXCvCsflSUGoWYlYA/96SJNIdMztOnNL4MnTTdLB3 cL8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684837778; x=1687429778; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/T9opHzMSw2R0AZ40N9B37p3pMgsnkJKDx5J8AZzmBw=; b=ctLobPMYyFyqLH+LkIMWE/IzqXd9wdwH6Ho9E6RBOVNTPyxwc6k8ALt4NPFisoXTqM xffXlyZnCRw20iA/GTGtMSiLA1UxUI68atA/KfTbc7FOdsMzOtLgP+t87jwzt4MCo+jo jh0rgxf0Bg4P0TRBBS6b3or0IZfKL85JrdTstO3n2gFpTSdswmsju5dzo+bwpPo31qtj /3TZVvuaHh1C2B1QN0QX130AJVhOsLjGl26a02Kupg52fyL+n0xOpr98wJ04JB/i1vL4 LIqP5p2PpEME060F8UE0Ru87BtqxNYtrNuZ74ozVLQO/3WKnK2AB6yqxXN1pKzpc1htS SfjQ== X-Gm-Message-State: AC+VfDyz47nrPkKC19xzM1ZOOh2PGI3uEopzzRbXKD2V9V3E33NqOAVb 5HwJ8OP7tsZhOOehbUyLTABf0AlSlcgT8//uQZE= X-Google-Smtp-Source: ACHHUZ7NlztXsyfEPG7uRIrR/BDOKoTQuncAxl6jYjrOJQ0nYDERu3ZThn0B0l/rvpMhua0FzNqdag== X-Received: by 2002:ac2:4c8e:0:b0:4f3:b97c:2d88 with SMTP id d14-20020ac24c8e000000b004f3b97c2d88mr3307217lfl.63.1684837778508; Tue, 23 May 2023 03:29:38 -0700 (PDT) Received: from [192.168.1.101] (abyk138.neoplus.adsl.tpnet.pl. [83.9.30.138]) by smtp.gmail.com with ESMTPSA id b1-20020ac25e81000000b004f14591a942sm1279869lfq.271.2023.05.23.03.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 03:29:38 -0700 (PDT) Message-ID: <87b5dda1-be2b-d123-e026-176d4c732b3f@linaro.org> Date: Tue, 23 May 2023 12:29:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] interconnect: qcom: rpm: allocate enough data in probe() Content-Language: en-US To: Dan Carpenter Cc: Andy Gross , Bjorn Andersson , Georgi Djakov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 23.05.2023 12:27, Dan Carpenter wrote: > This was not allocating enough bytes. There are two issue here. > First, there was a typo where it was taking the size of the pointer > instead of the size of the struct, "sizeof(qp->intf_clks)" vs > "sizeof(*qp->intf_clks)". Second, it's an array of "cd_num" clocks so > we need to allocate space for more than one element. > > Fixes: 2e2113c8a64f ("interconnect: qcom: rpm: Handle interface clocks") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Konrad Dybcio Konrad > v2: allocate enough space for the array > > drivers/interconnect/qcom/icc-rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > index f4627c4a1bdd..6acc7686ed38 100644 > --- a/drivers/interconnect/qcom/icc-rpm.c > +++ b/drivers/interconnect/qcom/icc-rpm.c > @@ -436,7 +436,7 @@ int qnoc_probe(struct platform_device *pdev) > if (!qp) > return -ENOMEM; > > - qp->intf_clks = devm_kzalloc(dev, sizeof(qp->intf_clks), GFP_KERNEL); > + qp->intf_clks = devm_kcalloc(dev, cd_num, sizeof(*qp->intf_clks), GFP_KERNEL); > if (!qp->intf_clks) > return -ENOMEM; >