From: ebiederm@xmission.com (Eric W. Biederman)
To: kernel-janitors@vger.kernel.org
Subject: Re: [userns:userns-always-map-user-v46 78/99] include/linux/proc_fs.h:233:13: error: 'proc_ns_inode'
Date: Mon, 20 Aug 2012 07:37:00 +0000 [thread overview]
Message-ID: <87boi6vwtf.fsf@xmission.com> (raw)
In-Reply-To: <20120819115031.GA20588@localhost>
Fengguang Wu <fengguang.wu@intel.com> writes:
> Hi Eric,
>
> FYI, kernel build failed on
I was definitely missing an inline, but did that really cause a build failure?
Does sh set -Werr across the entire kerenl? That seems reckless.
Eric
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git userns-always-map-user-v46
> head: 271556925ff7981a48391295134f3245cf815bb6
> commit: 148991415a3e6b6da4381ef2f7a896c3cce7b58a [78/99] vfs: Add setns support for the mount namespace
> config: sh-allnoconfig (attached as .config)
>
> All related error/warning messages:
>
> In file included from init/main.c:14:0:
> include/linux/proc_fs.h:233:13: warning: 'proc_ns_inode' defined but not used [-Wunused-function]
> --
> In file included from include/linux/sunrpc/stats.h:12:0,
> from include/linux/sunrpc/clnt.h:21,
> from include/linux/nfs_fs.h:57,
> from init/do_mounts.c:30:
> include/linux/proc_fs.h:233:13: warning: 'proc_ns_inode' defined but not used [-Wunused-function]
> --
> In file included from drivers/tty/tty_io.c:88:0:
> include/linux/proc_fs.h:233:13: warning: 'proc_ns_inode' defined but not used [-Wunused-function]
> ..
>
> vim +233 include/linux/proc_fs.h
> 230 return ERR_PTR(-EINVAL);
> 231 }
> 232
> > 233 static bool proc_ns_inode(struct inode *inode)
> ^ missing inline
> 234 {
> 235 return false;
> 236 }
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu <wfg@linux.intel.com> Intel Corporation
next prev parent reply other threads:[~2012-08-20 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 11:50 [userns:userns-always-map-user-v46 78/99] include/linux/proc_fs.h:233:13: error: 'proc_ns_inode' def Fengguang Wu
2012-08-20 7:37 ` Eric W. Biederman [this message]
2012-08-20 8:26 ` [userns:userns-always-map-user-v46 78/99] include/linux/proc_fs.h:233:13: error: 'proc_ns_inode' Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boi6vwtf.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).