* [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check
@ 2018-06-11 16:46 Colin King
2018-06-12 9:10 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-06-11 16:46 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check for level being less than zero always false because flags
is currently unsigned and can never be negative. Fix this by making
flags a s32.
Detected by CoverityScan, CID#1468363 ("Macro compares unsigned to 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: Make flags s32 rather than remove the GEM_BUG_ON check, thanks to
Ville Syrjälä for spotting the mistake in my first attempt.
---
drivers/gpu/drm/i915/intel_guc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
index 116f4ccf1bbd..fb31f5004bcf 100644
--- a/drivers/gpu/drm/i915/intel_guc.c
+++ b/drivers/gpu/drm/i915/intel_guc.c
@@ -206,7 +206,7 @@ void intel_guc_fini(struct intel_guc *guc)
static u32 get_log_control_flags(void)
{
u32 level = i915_modparams.guc_log_level;
- u32 flags = 0;
+ s32 flags = 0;
GEM_BUG_ON(level < 0);
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check
2018-06-11 16:46 [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check Colin King
@ 2018-06-12 9:10 ` Dan Carpenter
2018-06-12 9:23 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2018-06-12 9:10 UTC (permalink / raw)
To: Colin King
Cc: David Airlie, intel-gfx, kernel-janitors, linux-kernel, dri-devel,
Rodrigo Vivi
On Mon, Jun 11, 2018 at 05:46:53PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for level being less than zero always false because flags
> is currently unsigned and can never be negative. Fix this by making
> flags a s32.
>
> Detected by CoverityScan, CID#1468363 ("Macro compares unsigned to 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> ---
> V2: Make flags s32 rather than remove the GEM_BUG_ON check, thanks to
> Ville Syrjälä for spotting the mistake in my first attempt.
> ---
> drivers/gpu/drm/i915/intel_guc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> index 116f4ccf1bbd..fb31f5004bcf 100644
> --- a/drivers/gpu/drm/i915/intel_guc.c
> +++ b/drivers/gpu/drm/i915/intel_guc.c
> @@ -206,7 +206,7 @@ void intel_guc_fini(struct intel_guc *guc)
> static u32 get_log_control_flags(void)
> {
> u32 level = i915_modparams.guc_log_level;
> - u32 flags = 0;
> + s32 flags = 0;
>
> GEM_BUG_ON(level < 0);
Only insane people use "s32" when it's not part of the hardware spec and
you changed the wrong variable...
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check
2018-06-12 9:10 ` Dan Carpenter
@ 2018-06-12 9:23 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2018-06-12 9:23 UTC (permalink / raw)
To: Dan Carpenter, Colin King
Cc: David Airlie, intel-gfx, kernel-janitors, linux-kernel, dri-devel,
Rodrigo Vivi
On Tue, 12 Jun 2018, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Jun 11, 2018 at 05:46:53PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The check for level being less than zero always false because flags
>> is currently unsigned and can never be negative. Fix this by making
>> flags a s32.
>>
>> Detected by CoverityScan, CID#1468363 ("Macro compares unsigned to 0")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> ---
>> V2: Make flags s32 rather than remove the GEM_BUG_ON check, thanks to
>> Ville Syrjälä for spotting the mistake in my first attempt.
>> ---
>> drivers/gpu/drm/i915/intel_guc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
>> index 116f4ccf1bbd..fb31f5004bcf 100644
>> --- a/drivers/gpu/drm/i915/intel_guc.c
>> +++ b/drivers/gpu/drm/i915/intel_guc.c
>> @@ -206,7 +206,7 @@ void intel_guc_fini(struct intel_guc *guc)
>> static u32 get_log_control_flags(void)
>> {
>> u32 level = i915_modparams.guc_log_level;
>> - u32 flags = 0;
>> + s32 flags = 0;
>>
>> GEM_BUG_ON(level < 0);
>
> Only insane people use "s32" when it's not part of the hardware spec and
> you changed the wrong variable...
Yeah, int level.
Also,
Fixes: cb5d64e9f13e ("drm/i915/guc: Allow user to control default GuC logging")
BR,
Jani.
>
> regards,
> dan carpenter
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-12 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-11 16:46 [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check Colin King
2018-06-12 9:10 ` Dan Carpenter
2018-06-12 9:23 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).