From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 15 Jan 2015 12:45:11 +0000 Subject: Re: [PATCH 6/8] adm8211: fix error return code Message-Id: <87fvbctdpk.fsf@kamboji.qca.qualcomm.com> List-Id: References: <1419872683-32709-1-git-send-email-Julia.Lawall@lip6.fr> <1419872683-32709-7-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1419872683-32709-7-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:41 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Julia Lawall writes: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // > > Signed-off-by: Julia Lawall Thanks, applied to wireless-drivers-next.git. -- Kalle Valo