From: Eric Anholt <eric@anholt.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/vc4: checking for NULL instead of IS_ERR
Date: Thu, 05 Nov 2015 01:40:12 +0000 [thread overview]
Message-ID: <87h9l1441v.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20151104132140.GA20966@mwanda>
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
Dan Carpenter <dan.carpenter@oracle.com> writes:
> vc4_plane_init() returns an ERR_PTR on error, it doesn't return NULL.
> This was obviously intended because the next lines call
> PTR_ERR(primary_plane) already.
>
> Fixes: c8b75bca92cb ('Eric Anholt <eric@anholt.net>')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Pulled this patch, should get it into 4.4. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2015-11-05 1:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 13:21 [patch] drm/vc4: checking for NULL instead of IS_ERR Dan Carpenter
2015-11-05 1:40 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9l1441v.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox