Re: [userns:for-next 10/23] ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!

Re: [userns:for-next 10/23] ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!

[Eric W. Biederman]

Fengguang Wu <fengguang.wu@intel.com> writes:

> Hi Eric,
>
> FYI, kernel build failed on
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
> head:   0625c883bc4b3eba6f93f268cf67b5664244c0fe
> commit: 4f82f45730c68fdaf9b0472495a965188404866e [10/23] net ip6 flowlabel: Make owner a union of struct pid * and kuid_t
> config: x86_64-allmodconfig (attached as .config)
>
> Build errors:
>
> ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!

Yes, and the next patch fixes that.

My apologies to git bisect users that the support for modular ipv6 is
not perfect.

Eric

Re: [userns:for-next 10/23] ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!

[Fengguang Wu]

On Tue, Aug 14, 2012 at 10:31:47PM -0700, Eric W. Biederman wrote:
> Fengguang Wu <fengguang.wu@intel.com> writes:
> 
> > Hi Eric,
> >
> > FYI, kernel build failed on
> >
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
> > head:   0625c883bc4b3eba6f93f268cf67b5664244c0fe
> > commit: 4f82f45730c68fdaf9b0472495a965188404866e [10/23] net ip6 flowlabel: Make owner a union of struct pid * and kuid_t
> > config: x86_64-allmodconfig (attached as .config)
> >
> > Build errors:
> >
> > ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!
> 
> Yes, and the next patch fixes that.
> 
> My apologies to git bisect users that the support for modular ipv6 is
> not perfect.

Fine for me - I normally build-in everything ;)

Thanks,
Fengguang

Re: [userns:for-next 10/23] ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!

[Eric W. Biederman]

Fengguang Wu <fengguang.wu@intel.com> writes:

> On Tue, Aug 14, 2012 at 10:31:47PM -0700, Eric W. Biederman wrote:
>> Fengguang Wu <fengguang.wu@intel.com> writes:
>> 
>> > Hi Eric,
>> >
>> > FYI, kernel build failed on
>> >
>> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
>> > head:   0625c883bc4b3eba6f93f268cf67b5664244c0fe
>> > commit: 4f82f45730c68fdaf9b0472495a965188404866e [10/23] net ip6 flowlabel: Make owner a union of struct pid * and kuid_t
>> > config: x86_64-allmodconfig (attached as .config)
>> >
>> > Build errors:
>> >
>> > ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!
>> 
>> Yes, and the next patch fixes that.
>> 
>> My apologies to git bisect users that the support for modular ipv6 is
>> not perfect.
>
> Fine for me - I normally build-in everything ;)

I guess that was my long winded way of saying once patches hit my
for-next branch I have no intention of rebasing to fix problems.

Now if you automated checker had gone to the base of my
userns-always-map-user-v46 branch where these patches were staged and
complained then I probably would have fixed the problem.

It looks like your checker limits itself to only the last 99 patches in
a branch and my branch has about 130 or so.

Eric

Re: [userns:for-next 10/23] ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!

[Fengguang Wu]

On Tue, Aug 14, 2012 at 11:34:58PM -0700, Eric W. Biederman wrote:
> Fengguang Wu <fengguang.wu@intel.com> writes:
> 
> > On Tue, Aug 14, 2012 at 10:31:47PM -0700, Eric W. Biederman wrote:
> >> Fengguang Wu <fengguang.wu@intel.com> writes:
> >> 
> >> > Hi Eric,
> >> >
> >> > FYI, kernel build failed on
> >> >
> >> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-next
> >> > head:   0625c883bc4b3eba6f93f268cf67b5664244c0fe
> >> > commit: 4f82f45730c68fdaf9b0472495a965188404866e [10/23] net ip6 flowlabel: Make owner a union of struct pid * and kuid_t
> >> > config: x86_64-allmodconfig (attached as .config)
> >> >
> >> > Build errors:
> >> >
> >> > ERROR: "free_pid_ns" [net/ipv6/ipv6.ko] undefined!
> >> 
> >> Yes, and the next patch fixes that.
> >> 
> >> My apologies to git bisect users that the support for modular ipv6 is
> >> not perfect.
> >
> > Fine for me - I normally build-in everything ;)
> 
> I guess that was my long winded way of saying once patches hit my
> for-next branch I have no intention of rebasing to fix problems.

Fair enough. I'll mark your for-next branch as non-rebaseable, and no
longer complaint about intermediate errors in it.

> Now if you automated checker had gone to the base of my
> userns-always-map-user-v46 branch where these patches were staged and
> complained then I probably would have fixed the problem.
> 
> It looks like your checker limits itself to only the last 99 patches in
> a branch and my branch has about 130 or so.

Good to know that - the limit could be trivially enlarged :)

Thanks,
Fengguang