From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Fri, 22 Jan 2016 12:21:20 +0000 Subject: Re: wireless-drivers: random cleanup patches piling up Message-Id: <87k2n1x0sf.fsf@kamboji.qca.qualcomm.com> List-Id: References: <87wpr3x9ln.fsf@kamboji.qca.qualcomm.com> <1453423965.3856.22.camel@perches.com> In-Reply-To: <1453423965.3856.22.camel@perches.com> (Joe Perches's message of "Thu, 21 Jan 2016 16:52:45 -0800") MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Joe Perches Cc: linux-wireless@vger.kernel.org, kbuild test robot , kernel-janitors , LKML Joe Perches writes: > On Thu, 2016-01-21 at 16:58 +0200, Kalle Valo wrote: >> Hi, >>=20 >> I have quite a lot of random cleanup patches from new developers waiting >> in my queue: >>=20 >> https://patchwork.kernel.org/project/linux-wireless/list/?state=10&deleg= ate%621&order=DAte >>=20 >> (Not all of them are cleanup patches, there are also few patches >> deferred due to other reasons, but you get the idea.) >>=20 >> These cleanup patches usually take quite a lot of my time and I'm >> starting to doubt the benefit, compared to the time needed to dig >> through them and figuring out what to apply. And this is of course time >> away from other patches, so it's slowing down "real" development. >>=20 >> I really don't know what to do. Part of me is saying that I just should >> drop them unless it's reviewed by a more experienced developer but on >> the other hand this is a good way get new developers onboard. >>=20 >> What others think? Are these kind of patches useful? > > Some yes, mostly not really. > > While whitespace style patches have some small value, > very few of the new contributors that use tools like > "scripts/checkpatch.pl -f" on various kernel files=C2=A0 > actually continue on to submit actual defect fixing > or optimization or code clarity patches. That's also my experience from maintaining wireless-drivers for a year, this seems to be a "hit and run" type of phenomenon. --=20 Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html