From: Peter Korsgaard <jacmet@sunsite.dk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg()
Date: Fri, 18 Jan 2013 08:39:44 +0000 [thread overview]
Message-ID: <87k3rakhpr.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130118074138.GA31793@elgon.mountain>
>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> The callers expect this function to return zero on success or -EIO if it
Dan> times out. The type should be int instead of unsigned short.
Dan> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Dan> diff --git a/drivers/usb/c67x00/c67x00-ll-hpi.c b/drivers/usb/c67x00/c67x00-ll-hpi.c
Dan> index a9636f4..3a1ca4d 100644
Dan> --- a/drivers/usb/c67x00/c67x00-ll-hpi.c
Dan> +++ b/drivers/usb/c67x00/c67x00-ll-hpi.c
Dan> @@ -237,7 +237,7 @@ void c67x00_ll_hpi_disable_sofeop(struct c67x00_sie *sie)
Dan> /* -------------------------------------------------------------------------- */
Dan> /* Transactions */
Dan> -static inline u16 ll_recv_msg(struct c67x00_device *dev)
Dan> +static inline int ll_recv_msg(struct c67x00_device *dev)
Dan> {
Dan> u16 res;
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2013-01-18 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 7:41 [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg() Dan Carpenter
2013-01-18 8:39 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3rakhpr.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox