From: Robert Jarzmik <robert.jarzmik@free.fr>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] ARM: pxa: pxa_cplds: signedness bug in probe
Date: Wed, 13 May 2015 19:52:29 +0000 [thread overview]
Message-ID: <87lhgsl0g2.fsf@belgarion.home> (raw)
In-Reply-To: <20150513113239.GA31617@mwanda> (Dan Carpenter's message of "Wed, 13 May 2015 14:32:39 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> "base_irq" needs to be signed for the error handling to work. Also we
> can remove the initialization because we re-assign it later.
Indeed.
I suppose smatch found this one with :
arch/arm/mach-pxa/pxa_cplds_irqs.c:126 cplds_probe() warn: unsigned
'base_irq' is never less than zero.
I still don't see which tool found the "re-assign" part ...
Anyway, thanks for this, I'll queue it in pxa/fixes.
Cheers.
--
Robert
prev parent reply other threads:[~2015-05-13 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 11:32 [patch] ARM: pxa: pxa_cplds: signedness bug in probe Dan Carpenter
2015-05-13 19:52 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhgsl0g2.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox