From: Jani Nikula <jani.nikula@linux.intel.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
Alan Cox <alan@linux.intel.com>
Cc: kernel-janitors@vger.kernel.org, trivial@kernel.org,
dri-devel@lists.freedesktop.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] gma500: remove duplicate FB_REG09 define
Date: Mon, 09 Jun 2014 15:41:13 +0000 [thread overview]
Message-ID: <87ppiigkfa.fsf@intel.com> (raw)
In-Reply-To: <20140609152023.GO9600@mwanda>
Patrik, Alan -
Should you add a MAINTAINERS entry for gma500 with one or both of you as
maintainers? What's the status?
BR,
Jani.
On Mon, 09 Jun 2014, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The FB_REG09 define is cut and pasted twice so we can remove the second
> instance.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c
> index a97e38e..d75ecb3 100644
> --- a/drivers/gpu/drm/gma500/mid_bios.c
> +++ b/drivers/gpu/drm/gma500/mid_bios.c
> @@ -39,7 +39,6 @@ static void mid_get_fuse_settings(struct drm_device *dev)
> #define FB_REG06 0xD0810600
> #define FB_MIPI_DISABLE (1 << 11)
> #define FB_REG09 0xD0810900
> -#define FB_REG09 0xD0810900
> #define FB_SKU_MASK 0x7000
> #define FB_SKU_SHIFT 12
> #define FB_SKU_100 0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-06-09 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:20 [patch] gma500: remove duplicate FB_REG09 define Dan Carpenter
2014-06-09 15:41 ` Jani Nikula [this message]
2014-06-10 21:18 ` Patrik Jakobsson
2014-06-10 21:42 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppiigkfa.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox