From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CA0C432BE for ; Thu, 19 Aug 2021 22:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2F8E610A6 for ; Thu, 19 Aug 2021 22:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236724AbhHSWk0 (ORCPT ); Thu, 19 Aug 2021 18:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236508AbhHSWk0 (ORCPT ); Thu, 19 Aug 2021 18:40:26 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F5FC061757 for ; Thu, 19 Aug 2021 15:39:49 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id y23so7284018pgi.7 for ; Thu, 19 Aug 2021 15:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WX/qJVOnuFAI2moIv6OF4lqewvc4NdGxWkCdYilIaS4=; b=dIr051qis+9TSdlqlxkVlLOVanqfmbLXpUhEciivJ12h+asK6W8Lb8B1xQ5SOFx0ed hBWa5vXbV5b1XLr52yfjhKR12+utTBNZO8Ms6rSiPQtoDnQJGUQfsRj1N9qnjRpMnSko tbJ3maAALuUqpegMFAmcYb5xUkx8ZNp9IKaEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WX/qJVOnuFAI2moIv6OF4lqewvc4NdGxWkCdYilIaS4=; b=dOG4UCuayUgzLjhETH1wSNvsrwuZ9gxv9Ry6wzyqJdGEq1ERVslzDCGZtFSr2z++nw 7gp43RJmR2wNcoMAy9xkCvTDzeeSZwxfn2webiccAYb+VlPB60hN2flIz5FXpgEoZaKB QzJy12lMk9nUE/US0rZw9q2uK50WMUSpmoxkFu+lxDwRHNqPwv8UTBHLfuLCc2/QClx0 gshxbWDml2HraLDf+UODDIk1JunS0Zg5nFY+zXubrHwHXUdbdYBeiM/s8Yjqz3Ri8ymd VMV/w9YIeoNtJIEatR1BVqj3ydoJ+sc8Igf3StHbM0AcFgEE+BUVMnwFgge+N/Z6lhrY X1YA== X-Gm-Message-State: AOAM532LYRpvyzYvbBUVWm7Sto0CqRwN9cJSMeKc7CnP1/CudxOFnmek 2NUNadBchZSs4i5aRsGTjDdSqA== X-Google-Smtp-Source: ABdhPJydtoDgmtfFU7iCvzmfD+6LAiNa/sBr8PkQ4fFuCRed3yo4/Qn+wZAYqYuVMFMYpSUN+dNGhA== X-Received: by 2002:aa7:8e56:0:b029:3cd:c2ec:6c1c with SMTP id d22-20020aa78e560000b02903cdc2ec6c1cmr16390211pfr.80.1629412788706; Thu, 19 Aug 2021 15:39:48 -0700 (PDT) Received: from localhost ([2001:4479:e000:e400:3a83:f47e:d5a3:378a]) by smtp.gmail.com with ESMTPSA id x69sm4639869pfc.59.2021.08.19.15.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 15:39:48 -0700 (PDT) From: Daniel Axtens To: Lukas Bulwahn , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Michael Neuling , Anshuman Khandual , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Lukas Bulwahn , kernel-janitors@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com> References: <20210819113954.17515-1-lukas.bulwahn@gmail.com> <20210819113954.17515-2-lukas.bulwahn@gmail.com> Date: Fri, 20 Aug 2021 08:39:45 +1000 Message-ID: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Hi Lukas, > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > index e45644657d49..ff581d70f20c 100644 > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER > config KVM_BOOK3S_64_HANDLER > bool > select KVM_BOOK3S_HANDLER > - select PPC_DAWR_FORCE_ENABLE I looked at some of the history here. It looks like this select was left over from an earlier version of the patch series that added PPC_DAWR: v2 of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4 that new symbol had disappeared but the select had not. v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/ v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/ The rest of the patch reasoning makes sense to me: DAWR support will be selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try to select it again anyway. Reviewed-by: Daniel Axtens Kind regards, Daniel > > config KVM_BOOK3S_PR_POSSIBLE > bool > -- > 2.26.2