* [PATCH][next] drm/edid: make read-only const array static
@ 2023-06-27 17:01 Colin Ian King
2023-06-28 8:25 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-06-27 17:01 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
Don't populate the const array on the stack, instead make it static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index e0dbd9140726..39b13417b749 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3962,7 +3962,7 @@ static int drm_cvt_modes(struct drm_connector *connector,
struct drm_display_mode *newmode;
struct drm_device *dev = connector->dev;
const struct cvt_timing *cvt;
- const int rates[] = { 60, 85, 75, 60, 50 };
+ static const int rates[] = { 60, 85, 75, 60, 50 };
const u8 empty[3] = { 0, 0, 0 };
for (i = 0; i < 4; i++) {
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] drm/edid: make read-only const array static
2023-06-27 17:01 [PATCH][next] drm/edid: make read-only const array static Colin Ian King
@ 2023-06-28 8:25 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2023-06-28 8:25 UTC (permalink / raw)
To: Colin Ian King, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
On Tue, 27 Jun 2023, Colin Ian King <colin.i.king@gmail.com> wrote:
> Don't populate the const array on the stack, instead make it static.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, pushed to drm-misc-next.
> ---
> drivers/gpu/drm/drm_edid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index e0dbd9140726..39b13417b749 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3962,7 +3962,7 @@ static int drm_cvt_modes(struct drm_connector *connector,
> struct drm_display_mode *newmode;
> struct drm_device *dev = connector->dev;
> const struct cvt_timing *cvt;
> - const int rates[] = { 60, 85, 75, 60, 50 };
> + static const int rates[] = { 60, 85, 75, 60, 50 };
> const u8 empty[3] = { 0, 0, 0 };
Side note, this could be removed by replacing
if (!memcmp(cvt->code, empty, 3))
with
if (!memchr_inv(cvt->code, 0, 3))
or even
if (!cvt->code[0] && !cvt->code[1] && !cvt->code[2])
BR,
Jani.
>
> for (i = 0; i < 4; i++) {
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-28 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-27 17:01 [PATCH][next] drm/edid: make read-only const array static Colin Ian King
2023-06-28 8:25 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).