From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kalle Valo <kvalo@codeaurora.org>
Date: Wed, 24 Oct 2018 05:50:52 +0000
Subject: Re: [PATCH] ath9k: Fix a locking bug in ath9k_add_interface()
Message-Id: <87tvlbuc3n.fsf@codeaurora.org>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20181019200842.7qclbjs547sm7mbn@kili.mountain>
In-Reply-To: <20181019200842.7qclbjs547sm7mbn@kili.mountain> (Dan Carpenter's
        message of "Fri, 19 Oct 2018 23:08:43 +0300")
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>, Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org

Dan Carpenter <dan.carpenter@oracle.com> writes:

> We tried to revert commit d9c52fd17cb4 ("ath9k: fix tx99 with monitor
> mode interface") but accidentally missed part of the locking change.
>
> The lock has to be held earlier so that we're holding it when we do
> "sc->tx99_vif = vif;" and also there in the current code there is a
> stray unlock before we have taken the lock.
>
> Fixes: 6df0580be8bc ("ath9k: add back support for using active monitor interfaces for tx99")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

commit 6df0580be8bc is on it's way to v4.20 so should I also queue this
to v4.20?

-- 
Kalle Valo